)]}'
{
  "commit": "1d3378762d8282b26b9200cf26a2bedcb0bd4155",
  "tree": "282918c1b135e4d443faf428f74668f5e80cc34d",
  "parents": [
    "2b2e1584ef6ddc352d829848a1433cdd036e965e"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Fri Sep 18 22:59:04 2020 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Sep 18 22:59:04 2020 +0000"
  },
  "message": "Fix FPDFText_GetCharBox() returning excessively tall char boxes.\n\nIn CPDF_TextPage::ProcessTextObject(), when the initial char box\ncalculation produces too small of a char box, the method compensates by\nusng the font size for the height, and the glyph width for the width.\nThe height compensation code uses the font size in the wrong unit, so it\nis 1000 times bigger than it needs to be. Fix this and update the\naffected test case to show FPDFText_GetCharBox() no longer returns\nexcessively tall char boxes.\n\nAlso update a FPDFText_GetRect() test case that suffers from the same\ncalculation issue. Now, the second line of hello_world.pdf, which uses a\nfont of size 16, now has a rectangle height of ~15 instead of ~19.\n\nBug: pdfium:1591\nChange-Id: I1641b882c11c2f06b8a610c9d1ae11c850cd5edf\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73772\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Hui Yingst \u003cnigi@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b355cc951238e42a52c7f99a7f513447b59346ba",
      "old_mode": 33188,
      "old_path": "core/fpdftext/cpdf_textpage.cpp",
      "new_id": "e138515999d6869ec40c384eb26648bde65dfc0c",
      "new_mode": 33188,
      "new_path": "core/fpdftext/cpdf_textpage.cpp"
    },
    {
      "type": "modify",
      "old_id": "56b2b278ac8117c438bfbcd15a1b5aba88f94fc2",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_text_embeddertest.cpp",
      "new_id": "73754ecc3c2292c9b0d5ca741fec5a4efe608e42",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_text_embeddertest.cpp"
    }
  ]
}
