)]}'
{
  "commit": "8a822e28adea47068d423a25154b45bdba49f183",
  "tree": "5482fe85c14efe346488f4d1be80392b908e745e",
  "parents": [
    "9778968ebcf520e51b4807f2f93d946e30538ed1"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Thu Oct 14 18:29:32 2021 +0000"
  },
  "committer": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Thu Oct 14 18:29:32 2021 +0000"
  },
  "message": "M94: Use more safe arithmetic in CFX_DIBBase\n\nMost of the calculations are \"safe\" because we know that the DIB\nhas validated sizes before allocating a buffer, and that calculations\nin terms of bytes won\u0027t overflow and will be within the buffer. But\ncalculations in terms of bits might create overflow in temporaries,\nso use safe arithmetic there instead.\n\nRe-arranging the order of operations thus converting to bytes first\nmight be one option, but we want to handle the 1 bpp case.\n\nTest would require large images that might not be possible on\nall platforms.\n\nBug: chromium:1253399\nChange-Id: I3c6c5b8b1f1bf3f429c7d377a8a84c5ab53cafd9\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85510\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n(cherry picked from commit a8b293732a0160d1bc1d5b0ad5744922f0f820d5)\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85950\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fc686670c2fd94c5d6d56d27fe8987c31d040162",
      "old_mode": 33188,
      "old_path": "core/fxge/dib/cfx_bitmapcomposer.cpp",
      "new_id": "90a65f2ec6a755b234582dc841a99ada6f1281a2",
      "new_mode": 33188,
      "new_path": "core/fxge/dib/cfx_bitmapcomposer.cpp"
    },
    {
      "type": "modify",
      "old_id": "467b8331b92f3a347a6331845e496b8ab7dbbfdc",
      "old_mode": 33188,
      "old_path": "core/fxge/dib/cfx_dibbase.cpp",
      "new_id": "112c33ae937a097272313c7b60e49a3120048fbd",
      "new_mode": 33188,
      "new_path": "core/fxge/dib/cfx_dibbase.cpp"
    },
    {
      "type": "modify",
      "old_id": "be641015ae5ded892dca5197e3e25cb2b5129642",
      "old_mode": 33188,
      "old_path": "core/fxge/dib/cfx_dibitmap.cpp",
      "new_id": "736ff8ab70b58e8132ef67e6e2a14a41a9b5f19e",
      "new_mode": 33188,
      "new_path": "core/fxge/dib/cfx_dibitmap.cpp"
    }
  ]
}
