)]}'
{
  "commit": "f96e865f15b1e8ea01bdc759aafc034b3ffed191",
  "tree": "b1f44587d7213749ba3b82fa702aed43584bdfd9",
  "parents": [
    "604e6dc6240fa5b43db013e534c978c43ad1af03"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Thu Oct 26 20:01:36 2023 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Oct 26 20:01:36 2023 +0000"
  },
  "message": "Fix incorrect font dictionary usage in GeneratePopupAP()\n\nWhen GeneratePopupAP() calls CPDF_DocPageData::GetFont(), GetFont()\nexpects a font dictionary. GeneratePopupAP() is incorrectly passing in\nthe resource dictionary for all fonts. This ultimately causes the font\nmapping code to ask the PDFium embedder for a font with no font name.\nFix this by generating the font dictionary and the font resources\ndictionary separately. Thus making it easy to call GetFont() with the\ncorrect dictionary.\n\nUpdate corpus tests to match the new behavior. In FPDFAnnotEmbedderTest,\nthe generated content stream is slightly different because the font\nmetrics are different. This then compresses differently, which is why\nthe expected PDF size has changed. This change is OK, because the test\ncase is checking for size differences.\n\nChange-Id: I313411864f993e096cbd41f440791bdf821bf268\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/113113\nReviewed-by: Nigi \u003cnigi@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4336bab4296d61fcf12b5037913f6ee30e91b1c0",
      "old_mode": 33188,
      "old_path": "DEPS",
      "new_id": "10200f4db05397fbe5bb1a37b1751755f8591ea7",
      "new_mode": 33188,
      "new_path": "DEPS"
    },
    {
      "type": "modify",
      "old_id": "3b0f7d9dcd98035d6b9090295149ff5142d21e13",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_generateap.cpp",
      "new_id": "e7f72564967f669b1001c065378654d49920cb77",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_generateap.cpp"
    },
    {
      "type": "modify",
      "old_id": "8ddba6ade75ea922554dfc54983462d8ca134d3e",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_annot_embeddertest.cpp",
      "new_id": "bc6681405d9a72bc660be5d94bd6428c76e83661",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_annot_embeddertest.cpp"
    }
  ]
}