)]}'
{
  "commit": "f1805084d8ec1a854ffa6e4f3d489aaa5c9818ab",
  "tree": "8497b85b77d49527f28cadb9532accc83ba4f119",
  "parents": [
    "0c6ef5db1914af83e97b0263d5a4bec826b7f3cd"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Tue Feb 27 01:37:47 2024 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Feb 27 01:37:47 2024 +0000"
  },
  "message": "Convert EXPECT_STREQ(x, y.c_str()) to EXPECT_EQ(x, y).\n\nThe objective is to stop calling .c_str() except when absolutely\nnecessary, as extracting a c_str() from one of our string types\nmay someday require UNSAFE_BUFFERS(). It also may leave the tests\nvulnerable to, say, injected NULs.\n\nThe gtest macros can handle these EXPECT_EQ comparisons so long\nas operator\u003d\u003d() is defined for the string type. The risk is that\na bug in operator\u003d\u003d() might propagate to other tests, but we\ntest this itself in other tests.\n\n-- Fix several places that were including a trailing NUL.\n\nChange-Id: I9bdbd857c45b2356719a19560a30c35a80b2bff5\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/116912\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Thomas Sepez \u003ctsepez@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4e2d9156cecb8be2642127c4f6ed0e3ac808ef1e",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/edit/cpdf_pagecontentgenerator_unittest.cpp",
      "new_id": "c168528508dec4559ce06b8091d5e2cb0f803a17",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/edit/cpdf_pagecontentgenerator_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "fdc35f15d7cb04f9d033f3720d2878dd91797ade",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_tounicodemap_unittest.cpp",
      "new_id": "7d7400c6762c73446a12f38811db9e7197d41270",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_tounicodemap_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "2d1ea048e2e793c9bf388453eb77591fe2d3f683",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/parser/cpdf_object_unittest.cpp",
      "new_id": "2f65f2189c06554c96bd3f2b4bcc3fe06572c4ae",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/parser/cpdf_object_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "48eaa8a3e3acf09f2039ccc9d28be7bc22e63633",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_filespec_unittest.cpp",
      "new_id": "adb1f3f31ae624d6571dc63380148a43af9e5800",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_filespec_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "d1609c511c9e4d417c4e1088ffe35ba070bc67b3",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_formfield_unittest.cpp",
      "new_id": "0e4b3e974fd2784c1ab75aeb0a3f0543de4658bb",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_formfield_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "a70359c5858c948917ee4780d89f419f30b25b08",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_nametree_unittest.cpp",
      "new_id": "8ee494d45f2017cb14a326d65b14781e4412da32",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_nametree_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "a0c69d6aa57a87af0492c168e5b94ff57aa255ee",
      "old_mode": 33188,
      "old_path": "core/fpdftext/cpdf_linkextract_unittest.cpp",
      "new_id": "02be2417d101fe72514b89e218a30e4602a84e9e",
      "new_mode": 33188,
      "new_path": "core/fpdftext/cpdf_linkextract_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "fd5b32db2905969df895366a2534cf7e9770855e",
      "old_mode": 33188,
      "old_path": "core/fxcrt/fx_coordinates_unittest.cpp",
      "new_id": "3b05eab0c7de399e13d75df82acecf5ee96e0ba1",
      "new_mode": 33188,
      "new_path": "core/fxcrt/fx_coordinates_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "a7854e9a225b570f5c2fdc3ce4ae04f663aa20a2",
      "old_mode": 33188,
      "old_path": "core/fxcrt/fx_string_wrappers_unittest.cpp",
      "new_id": "e05d9273716c2cc3bea3f9d64f044334d84a1699",
      "new_mode": 33188,
      "new_path": "core/fxcrt/fx_string_wrappers_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "b655c8334ebd73d21c6b2d203da7541e1dfd3916",
      "old_mode": 33188,
      "old_path": "core/fxge/fx_font_unittest.cpp",
      "new_id": "7e8b564e7202a33c34b0cb092885ce1ec807c95b",
      "new_mode": 33188,
      "new_path": "core/fxge/fx_font_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "38d8e729195a0a77c468e7194221c03c2df99224",
      "old_mode": 33188,
      "old_path": "core/fxge/win32/cfx_psrenderer_unittest.cpp",
      "new_id": "ec8ec2631c5c16c1e4cda25e7ce8491a16094471",
      "new_mode": 33188,
      "new_path": "core/fxge/win32/cfx_psrenderer_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "482341199ca1b1852ac051fee99015a0cff89172",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_annot_embeddertest.cpp",
      "new_id": "2983a7d9c8a1022d354e19129fd9e9bb40eb8065",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_annot_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "99567bc8ae8247eaaaae7585893aee75a53a26f1",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp",
      "new_id": "061024bdfc0cd336bb76c9600a6aa3872b202e40",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "4795c5ab6676e127da384831b3e89ef1d202bce5",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_view_embeddertest.cpp",
      "new_id": "38900f592251a1ecb5a8a68b9dcc1dd55e54b6d7",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_view_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "3a9d8efb018ef0237cbcac9dd054915f4f08785a",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_combo_box_edit_embeddertest.cpp",
      "new_id": "0c2c3341e2a890c78a560ae859c92153b88f938d",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_combo_box_edit_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "f0e13d2d7b533faf75cc9142a5795565dd0c6620",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit_embeddertest.cpp",
      "new_id": "0aaa0d4dbb691058403fa96f79a6abf2718ea460",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "ee1d9b1f00ae05c44ff3594398e30fd15fd8886b",
      "old_mode": 33188,
      "old_path": "fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp",
      "new_id": "c6bcc0e9807808e28ba5ab89f4495c53b30d21eb",
      "new_mode": 33188,
      "new_path": "fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "f8952afda723af8e44d015453dcbd8ced9f78396",
      "old_mode": 33188,
      "old_path": "fxjs/cfxjs_engine_embeddertest.cpp",
      "new_id": "32188e6404f11496ec39d98325da72e8468472bb",
      "new_mode": 33188,
      "new_path": "fxjs/cfxjs_engine_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "3184a5627bb0fa036452cbc56d2267f945380d1c",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_publicmethods_embeddertest.cpp",
      "new_id": "b23fadaacd2f3771ba425dbc8bbcee1b6ae0a2e4",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_publicmethods_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "724251cea6dcde2d038e7203b4654a7d173c2677",
      "old_mode": 33188,
      "old_path": "fxjs/xfa/cfxjse_formcalc_context_embeddertest.cpp",
      "new_id": "4f5f17406b9ea53da41af56335e557891aca86cb",
      "new_mode": 33188,
      "new_path": "fxjs/xfa/cfxjse_formcalc_context_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "6d8e52c7efd1e0ff0479255350db704651320473",
      "old_mode": 33188,
      "old_path": "testing/embedder_test.cpp",
      "new_id": "c436565e1862b7b76323d51f62ce84fd17b1e828",
      "new_mode": 33188,
      "new_path": "testing/embedder_test.cpp"
    },
    {
      "type": "modify",
      "old_id": "a5807177716d67ba8d2750fa536f1829a77e4f76",
      "old_mode": 33188,
      "old_path": "xfa/fde/cfde_texteditengine_unittest.cpp",
      "new_id": "67b516e0c7dc008f064ff040248fadaa2315d958",
      "new_mode": 33188,
      "new_path": "xfa/fde/cfde_texteditengine_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "737375a3d1bac1f0d6000ef380164626a04dacde",
      "old_mode": 33188,
      "old_path": "xfa/fde/cfde_textout_unittest.cpp",
      "new_id": "85c24f099aa48428197575345e39bd64eb7bdd66",
      "new_mode": 33188,
      "new_path": "xfa/fde/cfde_textout_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "ed57e8315a365cd7dbca7bb700df7b8e698f2ee0",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/cfgas_decimal_unittest.cpp",
      "new_id": "711cb23f5a46193939fb9a5ca3904daa1f657445",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/cfgas_decimal_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "93ff4c83822c2e292f1ee4145d3ea32b91794c3e",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/cfgas_stringformatter_unittest.cpp",
      "new_id": "32bd7071300624e9ff9782aa75653e2f7eee0409",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/cfgas_stringformatter_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "12ff8322e99fbfebc6c1f985d9f9aa5944efe627",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/formcalc/cxfa_fmexpression_unittest.cpp",
      "new_id": "a18bff1606857d253e1f2deac87d572685d47e50",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/formcalc/cxfa_fmexpression_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "00b1e3cebd49900476e27d401d674056c77c76fe",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/formcalc/cxfa_fmparser_unittest.cpp",
      "new_id": "3e7ac413db6b4ab3a1e07ed4742c1d835c53dcff",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/formcalc/cxfa_fmparser_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "68bea7c6ff70ca4033e0516bae24ceceea1b8d08",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/cxfa_measurement_unittest.cpp",
      "new_id": "243e9bb333d2754c1205b7fb0334dca1b1b3812e",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/cxfa_measurement_unittest.cpp"
    }
  ]
}