)]}' { "commit": "00936dc156309a3a211338e3f1882fa13fca37ab", "tree": "b4c8b97531c6a814a1ded44933f530fbe4aae7c3", "parents": [ "fdf2c51e4ee41fadabd7035d474397d491463f0c" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Jul 29 00:30:40 2021 +0000" }, "committer": { "name": "Pdfium LUCI CQ", "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 29 00:30:40 2021 +0000" }, "message": "Consolidate CFLW_PartState to FWLTHEME_STATE conversions\n\nThis is currently being done in three different ways in three\ndifferent places in xfa/fwl. All of them appear wrong because\neither:\n\n-- PartState is a bitmap so switching on it is wrong.\n-- \u0026ing it with 0x03 doesn\u0027t select the bits we want to test.\n-- \u0026ing it against a different type is not meaningful.\n-- Not all of the possibilities are covered sometimes.\n\nAdd a method GetThemeStates() that tests each bit in order of\nsome natural \"priority\".\n\n-- Inline DrawDropDownButton() methods into only callers.\n\nChange-Id: Iaef63405ed061212aff371dca0fe76001aec6a10\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83591\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "f7d5974f612997693d9ed34047ea9e62c8892c50", "old_mode": 33188, "old_path": "xfa/fwl/cfwl_themepart.cpp", "new_id": "69bdb376de372193bdcd6230f389230055527773", "new_mode": 33188, "new_path": "xfa/fwl/cfwl_themepart.cpp" }, { "type": "modify", "old_id": "77b9bc5ba59d3a02ca23b1c27d614c2ee61d6ca1", "old_mode": 33188, "old_path": "xfa/fwl/cfwl_themepart.h", "new_id": "fc1d1a69a46a425f4120c03cddb6473f3fd4f24a", "new_mode": 33188, "new_path": "xfa/fwl/cfwl_themepart.h" }, { "type": "modify", "old_id": "0d5695f230884fd6b9c63ee66cf47b2886ec916f", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_comboboxtp.cpp", "new_id": "969ccc33b82acd62ed7561e3e586a10bcb7a2279", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_comboboxtp.cpp" }, { "type": "modify", "old_id": "501f67a6096482ed286c5d4ade64ac570c623f62", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_comboboxtp.h", "new_id": "f218064378b1d4e8ffbc4df5f8cad0ad55f4827e", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_comboboxtp.h" }, { "type": "modify", "old_id": "c332b1b9936c9c6d4fc3e3945f8fcd8349e88b6c", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_datetimepickertp.cpp", "new_id": "24df85b2ccb9d0006c42111288ca0e9d1589e2df", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_datetimepickertp.cpp" }, { "type": "modify", "old_id": "951f7846a16d7de3da81acb332c914d435afb74e", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_datetimepickertp.h", "new_id": "c02c4221727c15d1456c6ffc123e032a9fe227b4", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_datetimepickertp.h" }, { "type": "modify", "old_id": "125119e7272a6bee144ad4b8b68b5c50f6df24e0", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_monthcalendartp.cpp", "new_id": "2f28c67b568fd7a9ac4dce81d193bc8d2a6c93e5", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_monthcalendartp.cpp" }, { "type": "modify", "old_id": "3cf68baed29f748b584bdac7f56891ac1e1a3649", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_monthcalendartp.h", "new_id": "15b3f6bc9137614b7d860896e5a4bd3914acca07", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_monthcalendartp.h" }, { "type": "modify", "old_id": "7e4cfcd70c96aadaf47cd12f34d6f0fe57f67f6e", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_scrollbartp.cpp", "new_id": "562d1a021a5a94cefa432d24391e370c08081ba0", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_scrollbartp.cpp" } ] }