tree 88fd10ded88b70e8c3b52faaaf126801fe562507
parent 22a8e1526aaff358db7bcf91f3836091a8df2003
author Tom Sepez <tsepez@chromium.org> 1663959767 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1663959767 +0000

Fix interaction between RetainPtr<T> and transparent comparisons.

The key is providing an implicit operator T* so that we can make
comparisons in terms of raw pointers in all cases. Unfortunately,
this now allows passing RetainPtr<T> as T* without an explicit
Get(), which is cleaner but will not catch the use of unretained
references.

-- remove now-redundant comparison functions.
-- kludge around some ambiguity in CPDF_DictionaryLocker

Change-Id: Ib06f665361f4efa514c6f028eb24af114f7506dc
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/98394
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>