commit 0bd749eae5f31b7a6623a7ff3d1496a598b46800
author Lei Zhang <thestig@chromium.org> Mon Jun 29 22:56:47 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Jun 29 22:56:47 2020 +0000
tree 7a2f9480d333ccdbb329c9cc6957388e2174abae
parent 660d05700773fda244c2b7071b198afab51550f8

Initialize CFWL_WidgetMgr::Item in the header.

Change-Id: Ide6c6e550aa637365d6b34826f82caaee660b45d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70922
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

xfa/fwl/cfwl_widgetmgr.cpp

diff --git a/xfa/fwl/cfwl_widgetmgr.cpp b/xfa/fwl/cfwl_widgetmgr.cpp
index bf06935..3549127 100644
--- a/xfa/fwl/cfwl_widgetmgr.cpp
+++ b/xfa/fwl/cfwl_widgetmgr.cpp
@@ -373,13 +373,6 @@
 
 CFWL_WidgetMgr::Item::Item() : CFWL_WidgetMgr::Item(nullptr) {}
 
-CFWL_WidgetMgr::Item::Item(CFWL_Widget* widget)
-    : pParent(nullptr),
-      pOwner(nullptr),
-      pChild(nullptr),
-      pPrevious(nullptr),
-      pNext(nullptr),
-      pWidget(widget),
-      iRedrawCounter(0) {}
+CFWL_WidgetMgr::Item::Item(CFWL_Widget* widget) : pWidget(widget) {}
 
 CFWL_WidgetMgr::Item::~Item() = default;

xfa/fwl/cfwl_widgetmgr.h

diff --git a/xfa/fwl/cfwl_widgetmgr.h b/xfa/fwl/cfwl_widgetmgr.h
index bc3b113..1f65037 100644
--- a/xfa/fwl/cfwl_widgetmgr.h
+++ b/xfa/fwl/cfwl_widgetmgr.h
@@ -73,14 +73,14 @@
     explicit Item(CFWL_Widget* widget);
     ~Item();
 
-    Item* pParent;
-    Item* pOwner;
-    Item* pChild;
-    Item* pPrevious;
-    Item* pNext;
+    Item* pParent = nullptr;
+    Item* pOwner = nullptr;
+    Item* pChild = nullptr;
+    Item* pPrevious = nullptr;
+    Item* pNext = nullptr;
     CFWL_Widget* const pWidget;
     std::unique_ptr<CXFA_Graphics> pOffscreen;
-    int32_t iRedrawCounter;
+    int32_t iRedrawCounter = 0;
   };
 
   CFWL_Widget* GetFirstSiblingWidget(CFWL_Widget* pWidget) const;