tree 9f9bd4975a11c4d817295b7d52e4dd39cc6eb6cf
parent cc965275f436267684a3f185ea3335e203cee6f9
author Tom Sepez <tsepez@chromium.org> 1406750632 -0700
committer Tom Sepez <tsepez@chromium.org> 1406750632 -0700

Speculative fix for uninitialized value in CFX_ByteString().

If somehow different length values could be obtained by two successive calls
to Doc_getFilePath() (and FieldBrowse() for that matter), and the method is
true to the API documentation that says "The return value always indicated
number of bytes required for the buffer, even when there is no buffer
specified, or the buffer size is less then required", then it is possible
to get a returned length describing memory beyond the current buffer.

We can make the corresponding JS_docGetFilePath() method more robust against
this case by applying better checks to the returned value.

This probably is unrelated since ASAN seems to be flagging the corresponding bug
as UAF, but doesn't hurt to make things more robust.

BUG=392956
R=jun_fang@foxitsoftware.com

Review URL: https://codereview.chromium.org/423233002