Remove bug_679643.in JS test - https://pdfium-review.googlesource.com/43311 removed the potentially dangerous code, so this test case can no longer trigger the situation with the null ObservePtr in CJS_Annot::set_name(). - This test case depends on this.getAnnots() returning a Widget, but the Acrobat getAnnots() implementation filters out Widgets. Since https://pdfium-review.googlesource.com/135230 is aligning the getAnnots() behavior with Acrobat, that breaks this test and there is no alternative API to get the Widget, AFAICT. Change-Id: I374ae77248c20988564d3d1a1ef53b29e7c22d63 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135330 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
diff --git a/testing/resources/javascript/bug_679643.in b/testing/resources/javascript/bug_679643.in deleted file mode 100644 index 5ebe312..0000000 --- a/testing/resources/javascript/bug_679643.in +++ /dev/null
@@ -1,140 +0,0 @@ -{{header}} -{{object 1 0}} << - /Type /Catalog - /Pages 2 0 R - /AcroForm 4 0 R - /OpenAction 10 0 R ->> -endobj -{{object 2 0}} << - /Type /Pages - /Count 1 - /Kids [ - 3 0 R - ] ->> -endobj -% Page number 0. -{{object 3 0}} << - /Type /Page - /Parent 2 0 R - /Resources << - /Font <</F1 15 0 R>> - >> - /Contents [21 0 R] - /MediaBox [0 0 612 792] - /Annots [7 0 R 8 0 R 9 0 R] ->> -endobj -% Forms -{{object 4 0}} << - /XFA [ - (xdp:xdp) 23 0 R - (form) 29 0 R - (</xdp:xdp>) 30 0 R - ] - /Fields [ - 5 0 R - ] ->> -endobj -% Fields -{{object 5 0}} << - /T (MyField) - /Kids [ - 6 0 R - ] - /Rect [100 100 400 400] ->> -endobj -{{object 6 0}} << - /Parent 5 0 R - /FT /Btn - /Kids [ - 7 0 R - 8 0 R - 9 0 R - ] - /Rect [200 200 220 220] ->> -endobj -{{object 7 0}} << - /Parent 6 0 R - /Type /Annot - /Subtype /Widget - /Rect [220 220 240 240] ->> -endobj -{{object 8 0}} << - /Parent 6 0 R - /Type /Annot - /Subtype /Widget - /Rect [240 240 260 260] ->> -endobj -{{object 9 0}} << - /Parent 6 0 R - /Type /Annot - /Subtype /Widget - /Rect [240 240 260 260] ->> -endobj -% OpenAction action -{{object 10 0}} << - /Type /Action - /S /JavaScript - /JS 11 0 R ->> -endobj -% JS program to execute -{{object 11 0}} << - {{streamlen}} ->> -stream -var theName = "MyField"; -function Mangles() { - app.alert('Starting ...'); - try { - var annots = this.getAnnots(); - annots[0].name = { - toString: () => { - app.alert('Firing ...'); - this.removeField(theName); - gc(); - return false; - } - }; - } catch (e) { - app.alert("failed: " + e); - } -} -Mangles(); -endstream -endobj -{{object 23 0}} << - {{streamlen}} ->> -stream -<?xml version="1.0" encoding="UTF-8"?> -<xdp:xdp xmlns:xdp="http://ns.adobe.com/xdp/"> -endstream -endobj -{{object 29 0}} << - {{streamlen}} ->> -stream -<config></config> -<template></template> -endstream -endobj -{{object 30 0}} << - {{streamlen}} ->> -stream -</xdp:xdp> -endstream -endobj -{{xref}} -{{trailer}} -{{startxref}} -%%EOF
diff --git a/testing/resources/javascript/bug_679643_expected.txt b/testing/resources/javascript/bug_679643_expected.txt deleted file mode 100644 index b576eae..0000000 --- a/testing/resources/javascript/bug_679643_expected.txt +++ /dev/null
@@ -1,2 +0,0 @@ -Alert: Starting ... -Alert: Firing ...