)]}'
{
  "commit": "19e4ef4da2b40afc54a00a6ca0dc67040d77d398",
  "tree": "a3c0be3f29d8b2c97080ff1bc68d07251060c582",
  "parents": [
    "3680498a68d0ac615eff1c604c922e36acf63f52"
  ],
  "author": {
    "name": "Alan Screen",
    "email": "awscreen@chromium.org",
    "time": "Fri May 06 21:57:15 2022 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri May 06 21:57:15 2022 +0000"
  },
  "message": "Fix component build when Skia is enabled\n\nSkFontMgr_custom_empty_factory.cpp should not be the default factory as\nthat precludes use of platform-specific versions.  For macOS this\nhighlighted a link time issue with component builds, as it competed\nwith SkFontMgr_mac_ct_factory.cpp.\n\nBegin cleanup by removing SkFontMgr_custom_empty_factory.cpp as a\ncommon source dependency.  At a minimum it is not needed for Android.\n\nFor macOS this results in the need to explicitly note the Apple\nfreameworks needed by Skia.  Also remove the duplicate source definition\nfor Android factory which has been included for all platforms.\n\nThis cleanup also shows that Windows and Linux/ChromeOS builds are\ndependent upon the custom empty font manager files.\n\nOnce the builds are adjusted it reveals that the embedder test hashes\nwere generated based upon usage of SkFontMgr_custom_empty_factory.  In\nthe case of macOS this means that SkFontMgr_mac_ct_factory is not\nactually being used.  Similar test hash behavior is also noticed for\nWindows, that SkFontMgr_win_dw_factory is not being used to get the\nembedder test hashes.\n\nDo not change the tests to use the platform-specific variations at\nthis time, and instead just do the minimum to enable Pdfium to do a\ncomponent build with Skia.\n\nBug: pdfium:1830\nChange-Id: I63610255bda020d8e25e8f17fd7198deedb5704d\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93378\nCommit-Queue: Alan Screen \u003cawscreen@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "173f8c7ce69a9f50832b6f0e8f4cca9e6e7d712e",
      "old_mode": 33188,
      "old_path": "skia/BUILD.gn",
      "new_id": "e3fb3cd039fe61fbaca1688a39e722c32de16fbc",
      "new_mode": 33188,
      "new_path": "skia/BUILD.gn"
    }
  ]
}