)]}' { "commit": "1d737ddad104f4d839ba2e9b38ab626250bf5685", "tree": "29d216e800728b3d64cef90aea503c69db005ffb", "parents": [ "e6d8821ff7d272ffd6ff171d769514187bc5ec08" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Sep 22 22:46:29 2021 +0000" }, "committer": { "name": "Pdfium LUCI CQ", "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 22 22:46:29 2021 +0000" }, "message": "Pass observed pointers by non-const ref.\n\nCurrently, we pass these as pointer to ObservedPtr\u003c\u003e per the old style\nguide recomendation, but this has lead to at least one bug where this\npointer to pointer arrangement checked the wrong level of pointer.\nThe style guide now permits this, but we still like to use sparingly.\n\nChange-Id: I11d289042264872063074e68b56736233bff500a\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85392\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "e45cad6e38df54d362cf398ef41e9e8233cd64bc", "old_mode": 33188, "old_path": "core/fxcrt/observed_ptr.h", "new_id": "6298c4671c643b423d4224421d05ace3aa4cd1e6", "new_mode": 33188, "new_path": "core/fxcrt/observed_ptr.h" }, { "type": "modify", "old_id": "cc2841baf20b5ab1039d536faa53b896852f9544", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_annothandlermgr.cpp", "new_id": "8d374d1c7c913daa1ba9dfc566b2271c79442796", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_annothandlermgr.cpp" }, { "type": "modify", "old_id": "54a790ef6c5c24ad46b5fe753e5f3530945de881", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_annothandlermgr.h", "new_id": "a1c833101c87f05fa7aeda674cdb1db52ac224a3", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_annothandlermgr.h" }, { "type": "modify", "old_id": "1e9b654888f39655ffdc0507f0eb9a4eaf5b8290", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_baannothandler.cpp", "new_id": "24a05f5e54b210d27e9dc00536ff105becadc379", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_baannothandler.cpp" }, { "type": "modify", "old_id": "c05554194a6e8010fa9a1ca876eb776308416b2a", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_baannothandler.h", "new_id": "2da9db2fd4dbb972b72e4c4c32e0a9919e784c0d", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_baannothandler.h" }, { "type": "modify", "old_id": "9beb114096f4a332d26f0410ec1c42bbb72af84b", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_baannothandler_embeddertest.cpp", "new_id": "f6d4befda2a1197f8114b8b98112b54e05390d27", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_baannothandler_embeddertest.cpp" }, { "type": "modify", "old_id": "cfc71cb490e461b2cdc07b08f3a39e63da2df0f9", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_formfillenvironment.cpp", "new_id": "cfbb422a198d5b03aa0f1aedd0f5d4c2c3717dfb", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_formfillenvironment.cpp" }, { "type": "modify", "old_id": "59fe4401c5a67d73a34f5ae1105372bd224665c8", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_formfillenvironment.h", "new_id": "238d69f5cc19639fdc987ea50cb66065d577e79c", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_formfillenvironment.h" }, { "type": "modify", "old_id": "5740addd014fdb9217c6e622a54d80563632461c", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_pageview.cpp", "new_id": "f22cd39a7b7a96eb76f6c79b6eca72d494686ed0", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_pageview.cpp" }, { "type": "modify", "old_id": "da074aa69a5917e1dcbeb9ea5e72446cbcd861bc", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_pageview.h", "new_id": "c58357e1fde288b69252601bc5e473e2192d6499", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_pageview.h" }, { "type": "modify", "old_id": "6b5c6cff28f3a973990ff2b01d2b42025f64ffcf", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_widgethandler.cpp", "new_id": "35f074bc650586e053cf85d2f4d8ab3761c32c81", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_widgethandler.cpp" }, { "type": "modify", "old_id": "c638f9cbb5a9f8c37cdab315f8d7a0f06d2867b0", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_widgethandler.h", "new_id": "e5b2c608b97eb52826d6f24b82f88e447d96f1dc", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_widgethandler.h" }, { "type": "modify", "old_id": "d425d74a1ab2feac4bf047f6d081b80338f51e7e", "old_mode": 33188, "old_path": "fpdfsdk/formfiller/cffl_checkbox.cpp", "new_id": "59c2ea6d4713c8534ca26662f1c14be444fe19a0", "new_mode": 33188, "new_path": "fpdfsdk/formfiller/cffl_checkbox.cpp" }, { "type": "modify", "old_id": "e926b8e1bd2de8d060d670a45567b5a0e37e8744", "old_mode": 33188, "old_path": "fpdfsdk/formfiller/cffl_formfield.cpp", "new_id": "c67f0ec6cc28473c24f4173c2cd6b357ac44cb49", "new_mode": 33188, "new_path": "fpdfsdk/formfiller/cffl_formfield.cpp" }, { "type": "modify", "old_id": "78f5255e53e7abbe0f5a9ddec2542047982bb144", "old_mode": 33188, "old_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.cpp", "new_id": "91f17c48d4424f2bb2107dde92e978a16cf96efd", "new_mode": 33188, "new_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.cpp" }, { "type": "modify", "old_id": "5682c942d57aa86a24571896549b3f6d4ce11abf", "old_mode": 33188, "old_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.h", "new_id": "33f014d0e3d6c9b2057107d21094e6689e16d5af", "new_mode": 33188, "new_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.h" }, { "type": "modify", "old_id": "54a5d5023a57de90d898c277361dce5836aebec6", "old_mode": 33188, "old_path": "fpdfsdk/formfiller/cffl_radiobutton.cpp", "new_id": "402a1c50c7ab828a761c9e667e912c653474e83f", "new_mode": 33188, "new_path": "fpdfsdk/formfiller/cffl_radiobutton.cpp" }, { "type": "modify", "old_id": "58c9d035e93943c6fc63064beed9ef1cbde799da", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_formfill.cpp", "new_id": "0d07c2fbc1c30bcf7696d03a40441fdfaa9f0e40", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_formfill.cpp" }, { "type": "modify", "old_id": "2814217b2f88b6a47fa90d09641982646246097b", "old_mode": 33188, "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp", "new_id": "e2bf59b3e4e77756a13a351b90513749003f053d", "new_mode": 33188, "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp" }, { "type": "modify", "old_id": "54633c8363f011029a91eb51b95c62f227df9187", "old_mode": 33188, "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.cpp", "new_id": "ac36a669b784ac0265c35f28d04977b1e7db12c0", "new_mode": 33188, "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.cpp" }, { "type": "modify", "old_id": "1ec32bf8a3b4feda2cdfc6b2138264ed660ba2df", "old_mode": 33188, "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.h", "new_id": "eab6cf6b7c65d736c37d70fe83bca685f16b624a", "new_mode": 33188, "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.h" }, { "type": "modify", "old_id": "65aa389cb0df741c6a64f5268c68bde288a0a3f1", "old_mode": 33188, "old_path": "fpdfsdk/ipdfsdk_annothandler.cpp", "new_id": "926cf0783768761eef34b5d3536adf66226387d3", "new_mode": 33188, "new_path": "fpdfsdk/ipdfsdk_annothandler.cpp" }, { "type": "modify", "old_id": "1c42dcf741d5618a723540ece26a93a56c797d2c", "old_mode": 33188, "old_path": "fpdfsdk/ipdfsdk_annothandler.h", "new_id": "63daebbaa5d22129eb3989ace2e4717db4766a0a", "new_mode": 33188, "new_path": "fpdfsdk/ipdfsdk_annothandler.h" }, { "type": "modify", "old_id": "ae60a4d230ca4e96bde10e95178d20bca28dcc5d", "old_mode": 33188, "old_path": "fpdfsdk/pwl/cpwl_combo_box_embeddertest.cpp", "new_id": "e79fbbe267cf606aa26bcd018f47d69f8a9b98ac", "new_mode": 33188, "new_path": "fpdfsdk/pwl/cpwl_combo_box_embeddertest.cpp" }, { "type": "modify", "old_id": "739b44088fc733e9971ccd67a0d33dc9833e5a6b", "old_mode": 33188, "old_path": "fpdfsdk/pwl/cpwl_edit_embeddertest.cpp", "new_id": "fe44647660b8c57fbf82eaf6882958480c72fe3e", "new_mode": 33188, "new_path": "fpdfsdk/pwl/cpwl_edit_embeddertest.cpp" }, { "type": "modify", "old_id": "3bde235f8494aed1d59fd97c3f6a0f09f7083cf8", "old_mode": 33188, "old_path": "fpdfsdk/pwl/cpwl_special_button_embeddertest.cpp", "new_id": "31f366e49195efa37108b3a1e654618773c5cd64", "new_mode": 33188, "new_path": "fpdfsdk/pwl/cpwl_special_button_embeddertest.cpp" }, { "type": "modify", "old_id": "6469d69d968a415dd8b84409eb34da23ee74a4e2", "old_mode": 33188, "old_path": "fxjs/cjs_field.cpp", "new_id": "70027fe19494d51fa94a15b314bba93f711e0554", "new_mode": 33188, "new_path": "fxjs/cjs_field.cpp" } ] }