)]}'
{
  "commit": "216862ba4474438dd062eaba40abe8d27ffc8d85",
  "tree": "74501d92109838b976029b8a62a964ba605c1fd5",
  "parents": [
    "8f655643d7a3682f107eb1575db3811c443514dd"
  ],
  "author": {
    "name": "Lukasz Anforowicz",
    "email": "lukasza@google.com",
    "time": "Mon Oct 27 16:07:14 2025 -0700"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Oct 27 16:07:14 2025 -0700"
  },
  "message": "[rust png] Introduce `ProgressiveDecoder::PngReadMoreData`.\n\nThis CL stops calling `file_-\u003eReadBlockAtOffset` from\n`PngDetectImageTypeInBuffer` and `PngContinueDecode`.  These calls were\nundesirable because:\n\n* The code is duplicated across these 2 `Png...` methods\n* The code is subtly incorrect, by ignoring whether `codec_memory_` has\n  any data that hasn\u0027t yet been read by the decoder.  This wasn\u0027t an\n  issue yet, because `LibpngPngDecoder` (and the future\n  `SkiaPngDecoder`) always consume all the available data.  But this\n  meant that before this CL `LibpngPngDecoder` didn\u0027t have to\n  seek/advance `codec_memory_` - this was inconsistent with a WIP\n  Skia-based decoder implements [1] `SkStream::read` on top of\n  `CFX_CodecMemory::ReadBlock`.  This inconsistency was a source of\n  problems for interchangably using `LibpngPngDecoder` and\n  `SkiaPngDecoder`.\n\n[1] https://pdfium-review.googlesource.com/135730/30/core/fxcodec/png/skia_png_decoder.cpp#108\n\nBug: 444045690\nChange-Id: I439b96faa80ba98ee76d2aba87a998388816192c\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/137291\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "20367b3694b6f0e8be888a722598487d049ca9b9",
      "old_mode": 33188,
      "old_path": "core/fxcodec/png/libpng_png_decoder.cpp",
      "new_id": "92937716b4d1ce64c7502513e77cbfe7647ff8da",
      "new_mode": 33188,
      "new_path": "core/fxcodec/png/libpng_png_decoder.cpp"
    },
    {
      "type": "modify",
      "old_id": "e4e5cb9ee626a770b2fc84d85bbb1f94961a9239",
      "old_mode": 33188,
      "old_path": "core/fxcodec/progressive_decoder.cpp",
      "new_id": "c648b4d0b289671c44d380db63ece22416df2060",
      "new_mode": 33188,
      "new_path": "core/fxcodec/progressive_decoder.cpp"
    },
    {
      "type": "modify",
      "old_id": "7699de31fcefbe137d2f5724332ad27812ed05d3",
      "old_mode": 33188,
      "old_path": "core/fxcodec/progressive_decoder.h",
      "new_id": "46b38d9cd25e43aca7df8888b6d5d0b9e6339fe0",
      "new_mode": 33188,
      "new_path": "core/fxcodec/progressive_decoder.h"
    },
    {
      "type": "modify",
      "old_id": "9ebbe20ebdb2c7dcb6c1a5767a00002be5ffb223",
      "old_mode": 33188,
      "old_path": "core/fxcodec/progressive_decoder_unittest.cpp",
      "new_id": "30ac8779a76e51ded225defb9a2bc4df8d9c3a0d",
      "new_mode": 33188,
      "new_path": "core/fxcodec/progressive_decoder_unittest.cpp"
    }
  ]
}
