)]}' { "commit": "22923602f40e0fe3cdad7d3ce8828497e5e2a7fb", "tree": "47faf87a3da44e54b7df24618bb6fdc6e5e14c1b", "parents": [ "71f299c8a9fb0b0ecdee801409c6c66430e4c36d" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Mon Jul 15 21:33:35 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Mon Jul 15 21:33:35 2019 +0000" }, "message": "Remove const from public fpdfview types.\n\nThey contain (or are aliases for) parser objects, which are now\nrefcounted, and order to manipulate the internal refcounts, non-const\nobjects must be used. This avoids a number of const casts throughout\nthe codebase. Regrettably, there is some loss of const as a result.\n\nThis CL must happen first before we can use RetainPtr in a\nnumber of these classes.\n\nChange-Id: I0e894b56373ad35c68daf4499255be582699378d\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57853\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "8284913feecb2774934af1311c559e3a47701529", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_aaction.cpp", "new_id": "905be7c5871a92026c2420b196e5913c3e4cc207", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_aaction.cpp" }, { "type": "modify", "old_id": "edd3539745e2355c210050d26b9cd27e6b76b7e0", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_aaction.h", "new_id": "699d913d628b98093aa5e9d3425ffca4c9ac8663", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_aaction.h" }, { "type": "modify", "old_id": "18e49277924124c2596a286c3fbae1db530ae1c3", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_action.cpp", "new_id": "dc4f4854b274fb746904a0044ef4bd45db3c4f65", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_action.cpp" }, { "type": "modify", "old_id": "f0f86796ebd41dc2d1056e1ed076a313d81ec8e9", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_action.h", "new_id": "6ea1c638b6f53696b40387b6b621e8fc1e3e0081", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_action.h" }, { "type": "modify", "old_id": "7f7958b52a7736e795fe3eb5661ae26e3aabfaf5", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_bookmark.cpp", "new_id": "3a414ffc865c68fd10baaa538555fa8e16ca3eda", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_bookmark.cpp" }, { "type": "modify", "old_id": "47fd0715a37fe70792c7968fd1b6df70d354f821", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_bookmark.h", "new_id": "1081867fad3c7dfd8b04c4ab8bf889400bd8b062", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_bookmark.h" }, { "type": "modify", "old_id": "fc72db9c4a1a072d67364b57565d42d3dd117003", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_bookmarktree.cpp", "new_id": "ce7cfef6f415b1fa3f5d88ca4328303ce31310d3", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_bookmarktree.cpp" }, { "type": "modify", "old_id": "3729dfc737f99185b8f631549b5ddf3dd9325543", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_bookmarktree.h", "new_id": "b374bfa5b2f1c9a3b8d1ee46689b92adcd80462a", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_bookmarktree.h" }, { "type": "modify", "old_id": "1a373b6b9bae3a9b175aeee4e0ac3f418c2818b8", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_dest.cpp", "new_id": "511081f05c20bbbb9ff465fc20924268f3a3990a", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_dest.cpp" }, { "type": "modify", "old_id": "e6e673e6e311a07d3be6fb5443473be095892696", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_dest.h", "new_id": "4d9bfb8c9fbaec258c8d3858debb56167581fe6f", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_dest.h" }, { "type": "modify", "old_id": "0322faf4fd06cdb18e3d7f8538e3b2852db03e9a", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_formfield.cpp", "new_id": "b8d01f87c921d08647929651873b4ee39d694697", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_formfield.cpp" }, { "type": "modify", "old_id": "0481d5c9c3aec62cb1de034d783c15495ef525ea", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_viewerpreferences.cpp", "new_id": "9e63d37537a5ae52e6e14bf81761d9118a016c22", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_viewerpreferences.cpp" }, { "type": "modify", "old_id": "45e43900653d12b5443b6a7b6a114a9dd84713c7", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_viewerpreferences.h", "new_id": "ff2b1c8a41b29da918edd1c377ce8d885113b846", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_viewerpreferences.h" }, { "type": "modify", "old_id": "94bd8086444e32012c4c8cccec8679a091d5c789", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_formfillenvironment.cpp", "new_id": "9a5e72684ef063b1eb7f2db7dffb5bdbb3e052ed", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_formfillenvironment.cpp" }, { "type": "modify", "old_id": "97cebfd52fcffaf5ce3db11e31ad5ada79944eba", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_helpers.h", "new_id": "5d9522a12cd69df9d26a523b5803d70168a62d27", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_helpers.h" }, { "type": "modify", "old_id": "6552b8af5e8647765ecb13328f25126a17a5682b", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_doc.cpp", "new_id": "b9bf93d67ba981a5778a0c92c430b6ef5daa5b29", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_doc.cpp" }, { "type": "modify", "old_id": "3a53dcd7448f50876efbc498ded6f1347c271010", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_formfill.cpp", "new_id": "5293f052dd851771d4ffa4eb71a822bdf8e2d6f6", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_formfill.cpp" }, { "type": "modify", "old_id": "f5212599f258f91df7b28451e32189a1bf303398", "old_mode": 33188, "old_path": "public/fpdfview.h", "new_id": "6bbc2bfcd9ace729c61d2123664c42bf5dc36985", "new_mode": 33188, "new_path": "public/fpdfview.h" } ] }