tree cb9465e37aa1495d01adbed07d351ab36930e8e2
parent 5b2bc895384749493f2ec2ca818c485797448cae
author Tom Sepez <tsepez@chromium.org> 1452821108 -0800
committer Tom Sepez <tsepez@chromium.org> 1452821108 -0800

Cleanup CJS_PublicMethods::ParseNumber

Original patch by tombergan.

The old version of this function was basically strtod with a few quirks:

1. It always interpreted ',' as '.' independent of locale. I kept this
   behavior, to be conservative.

2. It interpreted the first non-number character as a decimal point,
   unless there was a prior decimal point, in which case all characters
   up to that point are ignored. This would parse "123z4" as "123.4"
   and "123xy6" as "6". I did not keep this behavior -- in the new code,
   these examples all fail to parse.

The new ParseNumber was inlined into ConvertStringToNumber, which
returns true on success and (false, 0) on failure.

BUG=pdfium:361
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1582013002 .