| commit | 2970d0dbc9db383e333264d4e0f4c506bf87378b | [log] [tgz] |
|---|---|---|
| author | Lei Zhang <thestig@chromium.org> | Thu Apr 15 20:36:06 2021 +0000 |
| committer | Chromium commit bot <commit-bot@chromium.org> | Thu Apr 15 20:36:06 2021 +0000 |
| tree | d52ec27615ea49d41829fb8f4469d2da963e2df7 | |
| parent | ae5785334fd8c385c46606c1186a83b80a3d294e [diff] |
Use explicit relative imports in skia_gold Python code. Implicit relative imports do not work in Python 3. Bug: pdfium:1674 Change-Id: I01c9cf8497ce116cfc9ee5f218396fcb65b6224a Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79491 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
diff --git a/testing/tools/skia_gold/__init__.py b/testing/tools/skia_gold/__init__.py index 3415b87..a16cacc 100644 --- a/testing/tools/skia_gold/__init__.py +++ b/testing/tools/skia_gold/__init__.py
@@ -1,4 +1,3 @@ -# pylint: disable=relative-import -import path_util +from . import path_util path_util.AddDirToPathIfNeeded(path_util.GetPDFiumDir(), 'build')
diff --git a/testing/tools/skia_gold/pdfium_skia_gold_properties.py b/testing/tools/skia_gold/pdfium_skia_gold_properties.py index b90d2c3..525b212 100644 --- a/testing/tools/skia_gold/pdfium_skia_gold_properties.py +++ b/testing/tools/skia_gold/pdfium_skia_gold_properties.py
@@ -4,11 +4,10 @@ # found in the LICENSE file. """PDFium implementation of //build/skia_gold_common/skia_gold_properties.py.""" -# pylint: disable=relative-import import subprocess import sys -import path_util +from . import path_util from skia_gold_common import skia_gold_properties
diff --git a/testing/tools/skia_gold/pdfium_skia_gold_session_manager.py b/testing/tools/skia_gold/pdfium_skia_gold_session_manager.py index 4eed413..55724b9 100644 --- a/testing/tools/skia_gold/pdfium_skia_gold_session_manager.py +++ b/testing/tools/skia_gold/pdfium_skia_gold_session_manager.py
@@ -5,8 +5,7 @@ """PDFium implementation of //build/skia_gold_common/skia_gold_session_manager.py.""" -# pylint: disable=relative-import -import pdfium_skia_gold_session +from . import pdfium_skia_gold_session from skia_gold_common import skia_gold_session_manager as sgsm SKIA_PDF_INSTANCE = 'pdfium'
diff --git a/testing/tools/skia_gold/skia_gold.py b/testing/tools/skia_gold/skia_gold.py index ca61f3f..112a560 100644 --- a/testing/tools/skia_gold/skia_gold.py +++ b/testing/tools/skia_gold/skia_gold.py
@@ -8,9 +8,8 @@ import shlex import shutil -# pylint: disable=relative-import -import pdfium_skia_gold_properties -import pdfium_skia_gold_session_manager +from . import pdfium_skia_gold_properties +from . import pdfium_skia_gold_session_manager GS_BUCKET = 'skia-pdfium-gm'