commit 2b7a4c5d6d7b05d5a90c73cac67737dab34a4003
author Tom Sepez <tsepez@chromium.org> Wed Aug 03 22:17:50 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 03 22:17:50 2022 +0000
tree 1b309f0b286514086cb0522518e489e4435ef6f5
parent 1dedc41f508bd74f1325331fc229c9d56ea62dbc

Avoid unnecessary string allocations on each call to MakeRoman().

Extracted from a larger CL which may or may not land.

Change-Id: Ic8d4e105d24f527f75a66b957aac9fdb6c9b1af2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/95993
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfdoc/cpdf_pagelabel.cpp

diff --git a/core/fpdfdoc/cpdf_pagelabel.cpp b/core/fpdfdoc/cpdf_pagelabel.cpp
index 6c35f43..909f77d 100644
--- a/core/fpdfdoc/cpdf_pagelabel.cpp
+++ b/core/fpdfdoc/cpdf_pagelabel.cpp
@@ -15,8 +15,9 @@
 
 WideString MakeRoman(int num) {
   const int kArabic[] = {1000, 900, 500, 400, 100, 90, 50, 40, 10, 9, 5, 4, 1};
-  const WideString kRoman[] = {L"m",  L"cm", L"d",  L"cd", L"c",  L"xc", L"l",
-                               L"xl", L"x",  L"ix", L"v",  L"iv", L"i"};
+  const WideStringView kRoman[] = {L"m",  L"cm", L"d",  L"cd", L"c",
+                                   L"xc", L"l",  L"xl", L"x",  L"ix",
+                                   L"v",  L"iv", L"i"};
   const int kMaxNum = 1000000;
 
   num %= kMaxNum;