commit 3331891d160e942effadaec0bd66962e303ec98d
author Tom Sepez <tsepez@chromium.org> Tue Oct 12 19:25:48 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 12 19:25:48 2021 +0000
tree 320afdb203591e3181782a1b65d80cdf3ed5c77a
parent 16186e16f0ef5ceb3aec828b23df637f10861ce9

Revert span usage in DrawGouraud().

CHECK is causing a crash; disable until we can diagnose where the
badly-sized span is created.

Bug: chromium:1258968
Change-Id: Ibce84a0654edb2225c37fd65f82a0693bfdcdc5d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85871
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fpdfapi/render/cpdf_rendershading.cpp

diff --git a/core/fpdfapi/render/cpdf_rendershading.cpp b/core/fpdfapi/render/cpdf_rendershading.cpp
index 08807f7..8c9a014 100644
--- a/core/fpdfapi/render/cpdf_rendershading.cpp
+++ b/core/fpdfapi/render/cpdf_rendershading.cpp
@@ -391,8 +391,7 @@
     int start_x = std::max(min_x, 0);
     int end_x = std::min(max_x, pBitmap->GetWidth());
 
-    uint8_t* dib_buf =
-        pBitmap->GetWritableScanline(y).subspan(start_x * 4).data();
+    uint8_t* dib_buf = pBitmap->GetWritableScanline(y).data() + start_x * 4;
     float r_unit = (r[end_index] - r[start_index]) / (max_x - min_x);
     float g_unit = (g[end_index] - g[start_index]) / (max_x - min_x);
     float b_unit = (b[end_index] - b[start_index]) / (max_x - min_x);