tree e7cd88e74dccb5d56241bd4cf809777dc86b42c6
parent 600248a4998a1154898bf9f800714c8c2bc48ee3
author Nico Weber <thakis@chromium.org> 1739302226 -0800
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1739302226 -0800

fixup_pdf_template: Don't count final newline in {{streamlen}}

Expansion of `{{streamlen}}` used to include the newline in front of
`endstream`.

macOS's Preview.app cannot load JPEG2000 files if they have an
additional `\n` byte at the end of the data, so don't count this
final newline.

With this, macOS's Preview.app now displays the PDF files generated
by fixup_pdf_template.py much better for
testing/resources/pixel/jpxdecode*.in

This requires adding newlines in a couple of tests that depend on
stream contents actually ending in a newline:

* bug_1236805: Apparently the type3 charprocs parser doesn't treat
               EOF as a token separator (?)
* bug_1395648: Added in https://pdfium-review.googlesource.com/102930
               as a regression test with a missing `/Filter` line.
               In the previous image in the text, the `ASCIIHexDecode`
               decode filter stripped newlines, but here it doesn't and
               the test needs the newline.

Bug: 394805680
Change-Id: I91610fe7d85080e5d4e0b3c52e2d5d10ff4b985d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128570
Reviewed-by: Nico Weber <thakis@google.com>
Commit-Queue: Nico Weber <thakis@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>