Use progressive rendering by default for corpus tests.
Currently pixel tests are using progressive rendering by default while
corpus tests are using oneshot rendering by default. To match pixel
tests and Chrome better, this CL makes corpus tests use progressive
rendering by default as well. This will help add a "render-oneshot"
runtime option for both pixel and corpus tests in the future.
Bug: pdfium:819
Change-Id: I0b6920cd33f78be3870861b380bb98fd6e60ee69
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/86410
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/testing/tools/run_corpus_tests.py b/testing/tools/run_corpus_tests.py
index c1bec3a..c81aea3 100755
--- a/testing/tools/run_corpus_tests.py
+++ b/testing/tools/run_corpus_tests.py
@@ -12,7 +12,6 @@
def main():
runner = test_runner.TestRunner('corpus')
runner.SetEnforceExpectedImages(True)
- runner.SetOneShotRenderer(True)
return runner.Run()
diff --git a/testing/tools/test_runner.py b/testing/tools/test_runner.py
index a7198cc..2485a3e 100644
--- a/testing/tools/test_runner.py
+++ b/testing/tools/test_runner.py
@@ -85,7 +85,6 @@
self.test_type = dirname
self.delete_output_on_success = False
self.enforce_expected_images = False
- self.oneshot_renderer = False
self.skia_tester = None
def GetSkiaGoldTester(self, process_name=None):
@@ -245,9 +244,6 @@
'--time=' + TEST_SEED_TIME
]
- if self.oneshot_renderer:
- cmd_to_run.append('--render-oneshot')
-
if use_ahem:
cmd_to_run.append('--font-dir=%s' % self.font_dir)
@@ -577,7 +573,3 @@
def SetEnforceExpectedImages(self, new_value):
"""Set whether to enforce that each test case provide an expected image."""
self.enforce_expected_images = new_value
-
- def SetOneShotRenderer(self, new_value):
- """Set whether to use the oneshot renderer. """
- self.oneshot_renderer = new_value
