)]}'
{
  "commit": "4ce737fdf669b7688a01490ffe37bf7c07a3530b",
  "tree": "5926c05f1a42c052dc968e7a90c1018b34c81dfd",
  "parents": [
    "295454b8b6e39860168a6afad3e611e287674f7a"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Wed May 22 02:10:39 2024 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed May 22 02:10:39 2024 +0000"
  },
  "message": "Fix crashes in FPDFAttachment_GetStringValue()\n\nWhen the key argument is \"CheckSum\", FPDFAttachment_GetStringValue() has\nsome special code to handle that case. This code path assumed the value\nof the checksum will always be a string, per spec. In the wild, the\nvalue could have some other type. Add some tests that would confuse the\nexisting implementation and cause a nullptr crash. Then fix the\nimplementation to not crash.\n\nChange-Id: I4cc7d6a568634512fa16ffa1bea15d9713cfa00f\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/119410\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Thomas Sepez \u003ctsepez@google.com\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ccc2154dae0febaddf1de69ef446647b1c79e0ee",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_attachment.cpp",
      "new_id": "8c86b84ebdcbd35f7df2f18ab4272e528f2295d6",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_attachment.cpp"
    },
    {
      "type": "modify",
      "old_id": "6c156d62134a2b345b7aecee4c16d6713c59394a",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_attachment_embeddertest.cpp",
      "new_id": "e87461fa3d1faeed03c538fc41385870d20435ac",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_attachment_embeddertest.cpp"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "6893408ea8199dedb3c1fb14d09fdcfa3b427065",
      "new_mode": 33188,
      "new_path": "testing/resources/embedded_attachments_invalid_types.in"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "509c8f40b17b6d60ce2cba79cf7e8438fbd01940",
      "new_mode": 33188,
      "new_path": "testing/resources/embedded_attachments_invalid_types.pdf"
    }
  ]
}