tree 9b99eab5095285b3f2b304701d78a32b334cb151
parent f0f676814adcc37da31c0a02075725a47cd43519
author Lei Zhang <thestig@chromium.org> 1554745811 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1554745811 +0000

Give buffers in experimental fpdf_annot.h APIs clearer types.

Change some buffer parameters' types from void* to FPDF_WCHAR*. Then:

- Clarify in the documentation that the buffer length is in bytes.
- Change callers to use containers of FPDF_WCHAR instead of char.
- Change callers to avoid casting and converting FPDF_WCHAR to char.
- Add GetFPDFWideStringBuffer() to help create std::vector<FPDF_WCHAR>
  without having to byte length to FPDF_WCHAR count conversions.
- Remove BufferToWString() and BufferToString() helpers.
- Check the md5sum of a large buffer, instead of just the two ends.

The affected APIs are:

- FPDFAnnot_GetStringValue()
- FPDFAnnot_GetAP()
- FPDFAnnot_GetOptionLabel()

Change-Id: Ie4fd1831af97221ea74d4353be2456758d6a945e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52872
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>