)]}' { "commit": "60044886a39365bbf10be7f8894a71dcd3275794", "tree": "510f99c2ab19f0e4c701395ce436077a170182a1", "parents": [ "f2095928371177683ee4e1a746f43633a43c303e" ], "author": { "name": "Hui Yingst", "email": "nigi@chromium.org", "time": "Tue Aug 13 22:33:13 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 13 22:33:13 2019 +0000" }, "message": "[SkiaPaths] Fix issue that non-Windows cannot load font correctly.\n\nWhen testing on barcode_test.pdf, error \"Could not create FT_Face.\\n\"\nis triggered. This is because |m_FontData| in the temporary CFX_Font\nin CFDE_TextOut::DrawString() is not initialized from |pFxFont|, which\nlater causes CFX_GlyphCache::GetDeviceCache() to fail at building a\nvalid |m_pTypeface|.\n\nTo fix this issue, initialize |m_FontData| in the temporary CFX_Font\nstructure with |m_FontData| from |pFxFont| to gain access to the font\ndata.\n\nThis CL also removes the unnecessary process of resetting |face| for\nthe temporary CFX_Font, since it will be destroyed automatically when\nCFDE_TextOut::DrawString() finishes.\n\nBug: pdfium:740\nChange-Id: I5e4da4e1928ce21d98393d84f81e58c2a7e479eb\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59220\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "d5a4a7e13bde40f20925d522e08dc227409d6f42", "old_mode": 33188, "old_path": "core/fxge/cfx_font.h", "new_id": "c7c7932033bce20823020c9b178797dd793de0ee", "new_mode": 33188, "new_path": "core/fxge/cfx_font.h" }, { "type": "modify", "old_id": "6e2915eedf10eb8705648e1c9338b4a6f307b2f7", "old_mode": 33188, "old_path": "xfa/fde/cfde_textout.cpp", "new_id": "39fcf20c575df853aec5ff2961ce0e73bb7a89c6", "new_mode": 33188, "new_path": "xfa/fde/cfde_textout.cpp" } ] }