commit 6287ebc38e5aafc256b6248caae710ea09d0ede4
author Oliver Chang <ochang@chromium.org> Fri Dec 18 14:27:56 2015 -0800
committer Oliver Chang <ochang@chromium.org> Fri Dec 18 14:27:56 2015 -0800
tree 7aaa362c7c0806af8edf9f9a54bcef38f86e4839
parent 178086485892c9bb6aa0bf57ee449b33705e71c0

Fix a memory leak in CPDF_DataAvail::CheckHintTables

R=thestig@chromium.org, dml@google.com
BUG=pdfium:327

Review URL: https://codereview.chromium.org/1536113002 .

core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
index e098112..97f1703 100644
--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
@@ -3600,10 +3600,11 @@
   m_syntaxParser.InitParser(m_pFileRead, m_dwHeaderOffset);
   nonstd::unique_ptr<CPDF_HintTables> pHintTables(
       new CPDF_HintTables(this, pDict));
-  CPDF_Stream* pHintStream = (CPDF_Stream*)ParseIndirectObjectAt(szHSStart, 0);
-  if (pHintStream && pHintStream->GetType() == PDFOBJ_STREAM &&
-      pHintTables->LoadHintStream(pHintStream))
-    m_pHintTables.reset(pHintTables.release());
+  nonstd::unique_ptr<CPDF_Object, ReleaseDeleter<CPDF_Object>> pHintStream(
+      ParseIndirectObjectAt(szHSStart, 0));
+  CPDF_Stream* pStream = ToStream(pHintStream.get());
+  if (pStream && pHintTables->LoadHintStream(pStream))
+    m_pHintTables = nonstd::move(pHintTables);
 
   m_docStatus = PDF_DATAAVAIL_DONE;
   return TRUE;