tree ad5ebfd6bb73d0db5c5b81b61597c7b0f18f9a0f
parent d8d6f55140bd4f0a67de833346113cfa6e03c4bd
author Dan Sinclair <dsinclair@chromium.org> 1518625201 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1518625201 +0000

Cleanup CXFA_Node::SetFlag

The SetFlag method has a signature of (flag, bool) which, looking at the
callsites makes you think it will set the flag to the boolean. This
isn't what happens, the flag is always set to true and the boolean
decides if we execute some notification code.

This CL splits SetFlag into SetFlag(flag) and SetFlagAndNotify(flag) to
make it a lot clearer what is happening.

Change-Id: I3e067c87532cce10b94bda10cc88feb62b948eb0
Reviewed-on: https://pdfium-review.googlesource.com/26750
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>