)]}'
{
  "commit": "75ff13168ea0fd0c8ac8981722d15cce07fbdcf9",
  "tree": "d7bf16029999b8cb6ebcddf436bfbd14d3f22831",
  "parents": [
    "a836c20b87e15724980fbec73229b7dee531fca8"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Wed Sep 13 00:16:28 2023 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Sep 13 00:16:28 2023 +0000"
  },
  "message": "Reinstate CPDF_FormField DCHECKs and improve SetValue()\n\nUndo a small portion of https://pdfium-review.googlesource.com/111552\nso SetItemSelection() and IsItemSelected() get their DCHECKs back.\nInstead, fix the issue by changing the caller to avoid tripping the\nDCHECKs. As part of this work:\n\n- Use CHECK instead of DCHECK, per modern coding guidelines.\n- Add an IsComboOrListField() helper function and use that everywhere.\n- Add a HasOptField() helper function and use that as an additional\n  guardrail to make sure CPDF_FormField only reads /Opt values when\n  appropriate.\n- Update FPDFAnnot_IsOptionSelected() to avoid tripping over the /Opt\n  checks.\n\nBug: chromium:1477093\nChange-Id: Id774393afcd8e976ffa7f2ae869ceac9c9680b06\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111670\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f4a62bd585ff401174cbabbda68f8225f5e366c0",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_formfield.cpp",
      "new_id": "bfcb797d30025b4819aa28c85b3ec612694e5d1a",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_formfield.cpp"
    },
    {
      "type": "modify",
      "old_id": "cb7c96d0136c2b24a6194057b0286e02a0e6ccd5",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_annot.cpp",
      "new_id": "0cba33e24096e4e37a0001eacf73a7dcaf277f0b",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_annot.cpp"
    }
  ]
}