commit 804a0e3561f62000edde5989f3694c34b24cc9a3
author Lei Zhang <thestig@chromium.org> Thu May 21 20:57:16 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu May 21 20:57:16 2020 +0000
tree 14faabd1c1ea2540217e1697ae0c4716ab07ae92
parent 58e3578ba4901dec67b4f05503dd3f9f1f3cc582

Make presubmit scripts more consistent with Chromium's.

Change all presubmit scripts to consistently use list.extend().

Change-Id: I460c8216617ec0f82fae66e253171b687dcef3c6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70090
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 303f415..cf9a196 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -312,13 +312,16 @@
       x, white_list=(r'\.(?:c|cc|cpp|h)$',))
 
   results = []
-  results += _CheckUnwantedDependencies(input_api, output_api)
-  results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
-  results += input_api.canned_checks.CheckChangeLintsClean(
-      input_api, output_api, cpp_source_filter, LINT_FILTERS)
-  results += _CheckIncludeOrder(input_api, output_api)
-  results += _CheckTestDuplicates(input_api, output_api)
-  results += _CheckPNGFormat(input_api, output_api)
+  results.extend(_CheckUnwantedDependencies(input_api, output_api))
+  results.extend(
+      input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
+  results.extend(
+      input_api.canned_checks.CheckChangeLintsClean(input_api, output_api,
+                                                    cpp_source_filter,
+                                                    LINT_FILTERS))
+  results.extend(_CheckIncludeOrder(input_api, output_api))
+  results.extend(_CheckTestDuplicates(input_api, output_api))
+  results.extend(_CheckPNGFormat(input_api, output_api))
 
   for f in input_api.AffectedFiles():
     path, name = input_api.os_path.split(f.LocalPath())

fpdfsdk/PRESUBMIT.py

diff --git a/fpdfsdk/PRESUBMIT.py b/fpdfsdk/PRESUBMIT.py
index 17f7c6a..dee2035 100644
--- a/fpdfsdk/PRESUBMIT.py
+++ b/fpdfsdk/PRESUBMIT.py
@@ -32,11 +32,11 @@
 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
-  results += _CheckApiTestFile(input_api, output_api)
+  results.extend(_CheckApiTestFile(input_api, output_api))
   return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
   results = []
-  results += _CheckApiTestFile(input_api, output_api)
+  results.extend(_CheckApiTestFile(input_api, output_api))
   return results

public/PRESUBMIT.py

diff --git a/public/PRESUBMIT.py b/public/PRESUBMIT.py
index 5081823..6138c4a 100644
--- a/public/PRESUBMIT.py
+++ b/public/PRESUBMIT.py
@@ -24,11 +24,11 @@
 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
-  results += _CheckPublicHeaders(input_api, output_api)
+  results.extend(_CheckPublicHeaders(input_api, output_api))
   return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
   results = []
-  results += _CheckPublicHeaders(input_api, output_api)
+  results.extend(_CheckPublicHeaders(input_api, output_api))
   return results