tree 2b18ae05605fff4670232a460a59b0e5f6664046
parent 06d1acb7eb78a56699be59ca7f1d4fdf2bf64692
author Tom Sepez <tsepez@chromium.org> 1557162555 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1557162555 +0000

Replace some CPDF_Dictionary::SetFor() calls with SetNewFor<>()

SetNewFor<>() is safer because it can not introduce a direct
cycle of objects into the dictionary since it creates a new object
that can not have references to any old objects [cycles through
indirect objects are always possible, but do not affect memory
management when using RetainPtr<>].

This reduces the number of NewFor() calls that might need auditing
should a cycle be discovered in dictionaries again someday.

Change-Id: I4d9e8b466a2562e39386d028cbee9f7c86a267c3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53832
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>