tree e3874db43b95a7538ab4baa083a5ee1a2d6bde6f
parent f8c67a228196c37af17e68d47195421e064b1cb5
author Tom Sepez <tsepez@chromium.org> 1557165479 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1557165479 +0000

Replace some CPDF_Array::Add() calls with AddNew<>().

Ditto for InsertAt() and SetAt().

AddNew<>() is safer because it can not introduce a direct
cycle of objects into the array since it creates a new object
that can not have references to any old objects [cycles through
indirect objects are always possible, but do not affect memory
management when using RetainPtr<>].

This reduces the number of Add() calls that might need auditing
should a cycle be discovered in arrays again someday.

Change-Id: Ic423fcd4baefed0c692bd60961b360f6bb506e43
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53870
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>