commit 8d732254fcc5cf84b6d1de12b2b38bec716498f1
author Tom Sepez <tsepez@chromium.org> Tue Nov 23 22:35:40 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 23 22:35:40 2021 +0000
tree c0b5e977870c07443e7d8402b3d2f30312802253
parent 64a3691918bca26c4d233c8c897d926a39e4a8b7

Fix nits is cpdfsdk_interactiveform.cpp.

-- Combine definition and initialization in one place.
-- use auto for return type of tellp(), since it is defined as
   type_traits::pos_type, for some type_traits, and could in theory
   be anything since pos_type is implementation-defined.

Change-Id: Idc0a38ab3e65cea519d0c1afb4171dce128474db
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/87371
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fpdfsdk/cpdfsdk_interactiveform.cpp

diff --git a/fpdfsdk/cpdfsdk_interactiveform.cpp b/fpdfsdk/cpdfsdk_interactiveform.cpp
index 357fc76..84fffe4 100644
--- a/fpdfsdk/cpdfsdk_interactiveform.cpp
+++ b/fpdfsdk/cpdfsdk_interactiveform.cpp
@@ -88,8 +88,7 @@
     CPDF_Dictionary* pField = pFields->GetDictAt(i);
     if (!pField)
       continue;
-    WideString name;
-    name = pField->GetUnicodeTextFor("T");
+    WideString name = pField->GetUnicodeTextFor("T");
     ByteString name_b = name.ToDefANSI();
     ByteString csBValue = pField->GetStringFor("V");
     WideString csWValue = PDF_DecodeText(csBValue.raw_span());
@@ -99,7 +98,7 @@
       fdfEncodedData << "&";
   }
 
-  size_t nBufSize = fdfEncodedData.tellp();
+  auto nBufSize = fdfEncodedData.tellp();
   if (nBufSize <= 0)
     return false;