tree ce7e69731ba8a92e55f26d2cf686a96eccc9c9d6
parent d7619d40b9ae8dfef7d9ed472c27276c7f0a27bd
author K Moon <kmoon@chromium.org> 1575574353 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1575574353 +0000

Enforce Python style on testing/tools

Opts PDFium testing/tools scripts into Pylint and auto-formatting,
following the directions at
https://chromium.googlesource.com/chromium/src/+/master/styleguide/python/python.md.

Cleaned up existing lint warnings:

1. Removed unused parameters and variables.
2. Renamed shadowing names.
3. Wrapped top-level statements to fix scoping issues.
4. Fixed a long line.
5. Suppressed warnings about (implicit) relative imports. Fixing this
   properly will require separating "scripts" and "packages".
6. Suppressed warnings about defining attributes in Run() methods.

Miscellaneous changes:

7. Filtered non-C++ files from top-level CheckChangeLintsClean check.
   (This check runs cpplint, and was triggering on PRESUBMIT.py.)

Change-Id: I8c25b3df433420bdfc9310e93f7e82d21396a458
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63153
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>