commit 8f083cead6e1107409851b71dc139c889f5b367f
author Lei Zhang <thestig@chromium.org> Tue Jan 24 23:42:34 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 24 23:42:34 2023 +0000
tree 06f81d5182761cb055db5c4025edcc84b259ce95
parent cd4ded5d4a9c07ff00498ca2b97dfd9b0a6171ed

Use more references in fx_skia_device.cpp.

Replace some pointers with references.

Change-Id: I3fa6a1b8dd60b663c7208a880dbba5eab62866ee
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103472
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxge/skia/fx_skia_device.cpp

diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index 12ad6b6..379163c 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -938,17 +938,17 @@
       const SkTDArray<SkPoint>& positions = m_charDetails.GetPositions();
       for (int index = 0; index < nChars; ++index) {
         const TextCharPos& cp = pCharPos[index];
-        SkRSXform* rsxform = &m_rsxform[index + original_count];
+        SkRSXform& rsxform = m_rsxform[index + original_count];
         if (cp.m_bGlyphAdjust) {
-          rsxform->fSCos = cp.m_AdjustMatrix[0];
-          rsxform->fSSin = cp.m_AdjustMatrix[1];
-          rsxform->fTx = cp.m_AdjustMatrix[0] * positions[index].fX;
-          rsxform->fTy = -cp.m_AdjustMatrix[3] * positions[index].fY;
+          rsxform.fSCos = cp.m_AdjustMatrix[0];
+          rsxform.fSSin = cp.m_AdjustMatrix[1];
+          rsxform.fTx = cp.m_AdjustMatrix[0] * positions[index].fX;
+          rsxform.fTy = -cp.m_AdjustMatrix[3] * positions[index].fY;
         } else {
-          rsxform->fSCos = 1;
-          rsxform->fSSin = 0;
-          rsxform->fTx = positions[index].fX;
-          rsxform->fTy = positions[index].fY;
+          rsxform.fSCos = 1;
+          rsxform.fSSin = 0;
+          rsxform.fTx = positions[index].fX;
+          rsxform.fTy = positions[index].fY;
         }
       }
     }
@@ -1538,17 +1538,17 @@
     xforms.resize(nChars);
     for (int index = 0; index < nChars; ++index) {
       const TextCharPos& cp = pCharPos[index];
-      SkRSXform* rsxform = &xforms[index];
+      SkRSXform& rsxform = xforms[index];
       if (cp.m_bGlyphAdjust) {
-        rsxform->fSCos = cp.m_AdjustMatrix[0];
-        rsxform->fSSin = cp.m_AdjustMatrix[1];
-        rsxform->fTx = cp.m_AdjustMatrix[0] * positions[index].fX;
-        rsxform->fTy = -cp.m_AdjustMatrix[3] * positions[index].fY;
+        rsxform.fSCos = cp.m_AdjustMatrix[0];
+        rsxform.fSSin = cp.m_AdjustMatrix[1];
+        rsxform.fTx = cp.m_AdjustMatrix[0] * positions[index].fX;
+        rsxform.fTy = -cp.m_AdjustMatrix[3] * positions[index].fY;
       } else {
-        rsxform->fSCos = 1;
-        rsxform->fSSin = 0;
-        rsxform->fTx = positions[index].fX;
-        rsxform->fTy = positions[index].fY;
+        rsxform.fSCos = 1;
+        rsxform.fSSin = 0;
+        rsxform.fTx = positions[index].fX;
+        rsxform.fTy = positions[index].fY;
       }
     }
     m_pCanvas->drawTextBlob(