)]}' { "commit": "960e2952565d197a8454e4fc24fe4997db5425f8", "tree": "c8c892813fa4e66caf2eb44a85adf0d325d15ab4", "parents": [ "590f4247e2358d258a06cc447c1ae89730184cc5" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed May 15 20:58:36 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Wed May 15 20:58:36 2019 +0000" }, "message": "Give buffers in experimental fpdf_attachment.h APIs clearer types.\n\nChange the buffer parameters\u0027 types from void* to FPDF_WCHAR*. Then:\n\n- Clarify in the documentation that the buffer length is in bytes.\n- Change callers to use containers of FPDF_WCHAR instead of char.\n- Change callers to avoid casting.\n- Use GetFPDFWideStringBuffer() to help create std::vector\u003cFPDF_WCHAR\u003e\n without having to byte length to FPDF_WCHAR count conversions.\n\nThe affected APIs are:\n\n- FPDFAttachment_GetName()\n- FPDFAttachment_GetStringValue()\n\nChange-Id: Ia077bcb7b04e49feeae1a2c04ed8fb58c8f9e2d0\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52890\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "259ed65e616a6ffb56ada73d4815f11a7d65036b", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_attachment.cpp", "new_id": "937b504fd70b024600a1b3df516b8ce8017cdd99", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_attachment.cpp" }, { "type": "modify", "old_id": "59508ee05b54fd19ca05b1aa9b3e52d714964578", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_attachment_embeddertest.cpp", "new_id": "7ce6003f96cb18728425747e11aa302cfa0d4cab", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_attachment_embeddertest.cpp" }, { "type": "modify", "old_id": "7b5597480079c2d8e55d5fae884b8fb2059b0971", "old_mode": 33188, "old_path": "public/fpdf_attachment.h", "new_id": "1c424f69dd10df1859f64605903468e1d25ed0a0", "new_mode": 33188, "new_path": "public/fpdf_attachment.h" }, { "type": "modify", "old_id": "5b3fe2d763e68ec6f75d9a9a1dddea91862e883f", "old_mode": 33188, "old_path": "samples/pdfium_test_write_helper.cc", "new_id": "23164a8843ad5e4a3e40acf0aa90b9fc95584bef", "new_mode": 33188, "new_path": "samples/pdfium_test_write_helper.cc" } ] }