tree c8c892813fa4e66caf2eb44a85adf0d325d15ab4
parent 590f4247e2358d258a06cc447c1ae89730184cc5
author Lei Zhang <thestig@chromium.org> 1557953916 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1557953916 +0000

Give buffers in experimental fpdf_attachment.h APIs clearer types.

Change the buffer parameters' types from void* to FPDF_WCHAR*. Then:

- Clarify in the documentation that the buffer length is in bytes.
- Change callers to use containers of FPDF_WCHAR instead of char.
- Change callers to avoid casting.
- Use GetFPDFWideStringBuffer() to help create std::vector<FPDF_WCHAR>
  without having to byte length to FPDF_WCHAR count conversions.

The affected APIs are:

- FPDFAttachment_GetName()
- FPDFAttachment_GetStringValue()

Change-Id: Ia077bcb7b04e49feeae1a2c04ed8fb58c8f9e2d0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52890
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>