tree aca579b05a05db5b4622d7b48e4bbeabdd7537cb
parent 595bc6e3fb24c18218b87798f93fb6328aa48bfe
author Tom Sepez <tsepez@chromium.org> 1575418684 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1575418684 +0000

Prevent fatal error in CFX_V8::PutObjectProperty()

If there is a user-supplied setter that throws, then
PutObjectProperty() will call v8::FromJust() on a Nothing, and

  #
  # Fatal error in v8::FromJust
  # Maybe value is Nothing.
  #

results.

- Make CFX_V8 return bool values as success indicators.
- Cover some empty object cases in cfx_v8_unittests.cpp
- Use a local to avoid clunky formatting.

Change-Id: I4ef5f38db4a1ad74491349211dd3b3c6a745bbef
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62970
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>