|author||Lei Zhang <email@example.com>||Mon Nov 02 13:29:26 2015 -0800|
|committer||Lei Zhang <firstname.lastname@example.org>||Mon Nov 02 13:29:26 2015 -0800|
Check fread() return values in CFX_FolderFontInfo::GetFontData(). Check fseek() return values too. BUG=549998 Remail@example.com Review URL: https://codereview.chromium.org/1419793003 .
Get the chromium depot tools via the instructions at http://www.chromium.org/developers/how-tos/install-depot-tools (this provides the gclient utilty needed below).
Also install Python, Subversion, and Git and make sure they're in your path.
The name of the top-level directory does not matter. In our examples, we use “repo”. This directory must not have been used before by
gclient config as each directory can only house a single gclient configuration.
mkdir repo cd repo gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git gclient sync cd pdfium
We use the GYP library to generate the build files.
At this point, you have two options. The first option is to use the [Ninja] (http://martine.github.io/ninja/) build system (also included with the depot_tools checkout). This is the default as of mid-September, 2015. Previously, the second option (platform-specific build files) was the default. Most PDFium developers use Ninja, as does our [continuous build system] (http://build.chromium.org/p/client.pdfium/).
The second option is to generate platform-specific build files, i.e. Makefiles on Linux, sln files on Windows, and xcodeproj files on Mac. To do so, set the GYP_GENERATORS environment variable appropriately (e.g. “make”, “msvs”, or “xcode”) before running the above command.
If you used Ninja, you can build the sample program by:
ninja -C out/Debug pdfium_test You can build the entire product (which includes a few unit tests) by:
ninja -C out/Debug.
If you're not using Ninja, then building is platform-specific.
The pdfium_test program supports reading, parsing, and rasterizing the pages of a .pdf file to .ppm or .png output image files (windows supports two other formats). For example:
out/Debug/pdfium_test --ppm path/to/myfile.pdf. Note that this will write output images to
There are currently several test suites that can be run:
It is possible the tests in the
testing directory can fail due to font differences on the various platforms. These tests are reliable on the bots. If you see failures, it can be a good idea to run the tests on the tip-of-tree checkout to see if the same failures appear.
The current health of the source tree can be found at http://build.chromium.org/p/client.pdfium/console
There are several mailing lists that are setup:
Note, the Reviews and Bugs lists are typically read-only.
We will be using this bug tracker, but for security bugs, please use [Chromium's security bug template] (https://code.google.com/p/chromium/issues/entry?template=Security%20Bug) and add the “Cr-Internals-Plugins-PDF” label.
For contributing code, we will follow Chromium's process as much as possible. The main exceptions are:
git cl land
There is a branch for a forthcoming feature called XFA that you can get by following the steps above, then:
git checkout origin/xfa build/gyp_pdfium ninja -C out/Debug
Merging to XFA requires:
git checkout origin/xfa git checkout -b merge_branch git branch --set-upstream-to=origin/xfa git cherry-pick -x <commit hash> git commit --amend # add Merge to XFA git cl upload
Then wait for approval, and
git cl land