tree ac19af0a27cfe483a35f726c5665319b3f6b81ec
parent 460f5dc134b34bce8d1aea2050a619ef4f040725
author Hui Yingst <nigi@chromium.org> 1587073110 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1587073110 +0000

Fix embedder test FPDFFormFillEmbedderTest.BUG_1281 for Skia.

When drawing the second bitmap with FPDF_REVERSE_BYTE_ORDER,
Skia/SkiaPaths renders a blue rectangle instead of a red one. This is
because |bRgbByteOrder| is ignored when setting color type for bitmap
inside CFX_SkiaDeviceDriver, while it's supposed to enforce the reverse
byte order of color.

For color rendering, Skia and SkiaPaths are always using color type
|kN32_SkColorType|, of which the value changes between
|kRGBA_8888_SkColorType| and |kBGRA_8888_SkColorType| depending on
whether the program is running on a big endian processor or not.

To make the byte order of color changeable instead of depending on the
processor, this CL makes Skia and SkiaPaths both respect the value of
|bRgbByteOrder| that's passed into CFX_SkiaDeviceDriver, and use
|m_bRgbByteOrder| to hold its value and keep the color type consistent
throughout the rendering process just like AGG.

In addition to the fix, this CL also adds the expected hash values for
Skia/SkiaPaths rendering results in the embedder test, since the small
discrepancies for rendering small rectangles are expected with
Skia/SkiaPaths enabled.

Bug: pdfium:1500
Change-Id: Iad0762a04cc3f266accb4d48177ccb8fd95af894
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68831
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>