tree 7f73c1226ebebf8e4799844ad07c6f1578d340d3
parent 064da53872c0bc9ff035ada88d1261e703944271
author K. Moon <kmoon@chromium.org> 1675455564 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1675455564 +0000

Use a stable sort to rank XFA font candidates

Uses std::stable_sort instead of std::sort to rank font candidates
within CFGAS_FontMgr::MatchFonts(). Using a non-stable sort leads to the
"best" candidate being selected non-deterministically, which interferes
with pixel tests, among other things.

This requires new Mac-specific expectations for xfa_node_caption.pdf, as
the matched font changes on this platform with stable sort; however,
future std::sort behavior changes shouldn't require additional updates.

Fixed: pdfium:1982
Change-Id: I458bd713521869b0ea8d4da8fbd3832cf1d57e4c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103590
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>