tree e89e3b2e24e47d3f1f077ef7ae6ec06c7a86210f
parent 779b542c6ae2fe9b70475a15617ef1deac5a6b9b
author Tom Sepez <tsepez@chromium.org> 1662136259 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1662136259 +0000

Avoid ambiguity in RetainPtr<> constructors

When two different RetainPtr<> types appear in an expression, and
one is convertible to the other but not vice-versa, SFINAE is not
of any help because the compiler first has to pick a direction in
which to convert (i.e. it won't try both and reject the one that
fails).

-- code taken from base/memory/scoped_refptr.h
-- add a test case that fails to compile without the patch.

Change-Id: I7fea264643bf4b9343336cf68253dcac7199a71b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/97351
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>