tree 914c5e3fba6e2cc0705e39514c6e5e609570216a
parent adc69fe695e79053e05f23fd8f8e61659a9e7d7f
author K. Moon <kmoon@chromium.org> 1674154815 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1674154815 +0000

Always return recorder from FPDF_RenderPageSkp()

Always returns a valid SkPictureRecorder from FPDF_RenderPageSkp(), in
order to better match the behavior of the other FPDF_RenderPage() APIs.

The other APIs accept a caller-provided destination, such as an
FPDF_Bitmap, while FPDF_RenderPageSkp() returns a non-null recorder
instead. This causes differences in behavior when FPDF_RenderPageSkp()
returns null for "errors" that the other APIs do not distinguish.

In particular, for XFA pages, CPDFPageFromFPDFPage() returns null, which
FPDF_RenderPageSkp() previously considered an error, while the other
APIs just skip rendering and defer all the real work to FPDF_FFLDraw().
(The equivalent API for FPDF_RenderPageSkp() is FPDF_FFLRecord().)

This change also reorders the CPDF_PageRenderContext assignments to make
the lifetime management a little more obvious.

Bug: pdfium:1929
Change-Id: Iee81b4f3a422b1616a543699ec901dc941849d41
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103373
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>