)]}' { "commit": "ac8357b3ec7e1fe4000ebcae5ce65a38bfeb5cb1", "tree": "3ba35d4111e491cf6f81eb5fe386d53001d8227e", "parents": [ "fffdeebfd0ed9806d32eb5609e0fdd015c25c5ac" ], "author": { "name": "Nicolas Pena", "email": "npm@chromium.org", "time": "Mon May 28 20:06:19 2018 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Mon May 28 20:06:19 2018 +0000" }, "message": "Revert \u0027Remove almost all usages of CFX_FixedBufGrow with std::vector\u0027\n\nThis is a manual revert of the CL at:\nhttps://pdfium-review.googlesource.com/c/pdfium/+/32159\n\nThe only file manually changed was cpdf_renderstatus.cpp\n\nReason for revert: the bug below shows that sometimes the vector size\nused is larger than the parameter given to CFX_FixedBufGrow. Thus, we\nwill revert, then add vectors using std::max unless it\u0027s clear from the\ncode that the code will never access indices outside.\n\nBug: chromium:847247\nChange-Id: Iee54af023c8564824418a7d34a6385b0bc418ff0\nReviewed-on: https://pdfium-review.googlesource.com/33050\nReviewed-by: dsinclair \u003cdsinclair@chromium.org\u003e\nCommit-Queue: Nicolás Peña Moreno \u003cnpm@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "354a342d90891f962b2286145c380d7d0ed627c7", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_colorspace.cpp", "new_id": "31c485fe032c233ecca923bcdcf1554ff3b35bf0", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_colorspace.cpp" }, { "type": "modify", "old_id": "ad828f237271990793a05e8ffc8865893c7470c1", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_dibsource.cpp", "new_id": "4241fb1b40ba8f94901e5fef763476ce5f506f65", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_dibsource.cpp" }, { "type": "modify", "old_id": "8c3c8796e46878349955274b59867aacd4055522", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_renderstatus.cpp", "new_id": "f99000bb695f34cad4234b27e8d48fe5e8d545b2", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_renderstatus.cpp" }, { "type": "modify", "old_id": "458816e77ea9fb67eda3c3e27cc4f96c6e178fec", "old_mode": 33188, "old_path": "core/fxcodec/codec/fx_codec_icc.cpp", "new_id": "29b37d19acd94918345959019359e33aedbd2df1", "new_mode": 33188, "new_path": "core/fxcodec/codec/fx_codec_icc.cpp" }, { "type": "modify", "old_id": "013be8f41482defd481b08ff69f20f1ddeac74d8", "old_mode": 33188, "old_path": "core/fxge/apple/fx_apple_platform.cpp", "new_id": "1801814e66ecbcd8bf421c336741e7a96ef87677", "new_mode": 33188, "new_path": "core/fxge/apple/fx_apple_platform.cpp" } ] }