)]}'
{
  "commit": "b6853cfe4fd1ee089dfdd0cb09bbc4063532ef82",
  "tree": "1404031e845c8b4b09d5a68fd81f09a7d2865d59",
  "parents": [
    "2a8a20cde4c8e2294f6868bb097fe450960a709f"
  ],
  "author": {
    "name": "tsepez",
    "email": "tsepez@chromium.org",
    "time": "Mon Apr 25 11:23:43 2016 -0700"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Apr 25 11:23:43 2016 -0700"
  },
  "message": "Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.\n\nToo many calls were of the form fn(x.c_str(), x.GetLength())\nwhich is an anti-pattern given the StringC classes which tie\nthese together.\n\nThere are a few places where explicit CFX_*StringCs are\nconstructed, but this can be avoided by changing the args\nto these functions in the same manner.\n\nRemoved String_ from name of functions since it added\nlittle value. Also removed default argument.\n\nReview URL: https://codereview.chromium.org/1919563002\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f1fd980120b480b6b398bc286751e8a1c64eeae5",
      "old_mode": 33188,
      "old_path": "core/fxcrt/fx_extension.cpp",
      "new_id": "53fcf45ef5bc1683a24a65a38ba72515debfba94",
      "new_mode": 33188,
      "new_path": "core/fxcrt/fx_extension.cpp"
    },
    {
      "type": "modify",
      "old_id": "7714999bbfae7897a1ef7226083f4f45f2a57dbb",
      "old_mode": 33188,
      "old_path": "core/fxcrt/fx_extension_unittest.cpp",
      "new_id": "954e0956edda665114fc8142c440511a0631072c",
      "new_mode": 33188,
      "new_path": "core/fxcrt/fx_extension_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "68ae2a36512048bf96041989715c7b4d4962e196",
      "old_mode": 33188,
      "old_path": "core/fxcrt/include/fx_ext.h",
      "new_id": "e956d3cb43d719dcdcd2fbc95b416930e7a3ac2b",
      "new_mode": 33188,
      "new_path": "core/fxcrt/include/fx_ext.h"
    },
    {
      "type": "modify",
      "old_id": "380713b425d79245fe0320051f926fd81ff385c0",
      "old_mode": 33188,
      "old_path": "fpdfsdk/javascript/global.cpp",
      "new_id": "043bd290ac7d90eb7288adff417b618662b6da34",
      "new_mode": 33188,
      "new_path": "fpdfsdk/javascript/global.cpp"
    },
    {
      "type": "modify",
      "old_id": "e23b4c6377c830bf9abe1650e85423bef185148b",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_csscache.cpp",
      "new_id": "9a259e1844e5b7b22dbf1d13c2a80c2e5c7e11cb",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_csscache.cpp"
    },
    {
      "type": "modify",
      "old_id": "6abe5a7a26be3e54d541d5ac9ce00a1387ec67c5",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssdatatable.cpp",
      "new_id": "f37f77b86c856fa0b0defa70b1fc8ce1b5ab5c85",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssdatatable.cpp"
    },
    {
      "type": "modify",
      "old_id": "8d17901d1d963278b2bbfc5bbfc437c503a4500b",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssdatatable.h",
      "new_id": "a066c29f944a0778cf0f7c1d50874e78d89b140a",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssdatatable.h"
    },
    {
      "type": "modify",
      "old_id": "5517d85cb22cf8bca602bd9168d9477b443bb278",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssdeclaration.cpp",
      "new_id": "e48372c2ed2ecd6bf9fb6c8939021171ef12dd34",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssdeclaration.cpp"
    },
    {
      "type": "modify",
      "old_id": "30502303f4419d1682c049734c094368857d0691",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstyleselector.cpp",
      "new_id": "4f88c0d5d7d2bb5dc54ec155f73e6e8f2e682b46",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstyleselector.cpp"
    },
    {
      "type": "modify",
      "old_id": "4afb0cee6352e44cd3759afbb2515a9824840ae4",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstylesheet.cpp",
      "new_id": "15358c2942314c4c051be97e886974b1b960e66e",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstylesheet.cpp"
    },
    {
      "type": "modify",
      "old_id": "8ae8bd539313e16820b5871076be453234724904",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstylesheet.h",
      "new_id": "21770bfe2bad3f4f4382bab63c6b1346d67a72c9",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstylesheet.h"
    },
    {
      "type": "modify",
      "old_id": "4734a0005e38b82ef398e867007950e6ae478515",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/fgas_codepage.cpp",
      "new_id": "36c40a64697ac280ccee1aa2c2d9049d78be73e3",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/fgas_codepage.cpp"
    },
    {
      "type": "modify",
      "old_id": "12271fbb64b17715576e7791a6c7e076d69ecd6a",
      "old_mode": 33188,
      "old_path": "xfa/fgas/font/fgas_fontutils.cpp",
      "new_id": "21d5d0b5a5a1be1a4b901b209be16f9c0db24097",
      "new_mode": 33188,
      "new_path": "xfa/fgas/font/fgas_fontutils.cpp"
    },
    {
      "type": "modify",
      "old_id": "9e8c824118ee825955ed4feef75953c78af45cdc",
      "old_mode": 33188,
      "old_path": "xfa/fgas/font/fgas_stdfontmgr.cpp",
      "new_id": "4b2a1422d2d7c30248616f6be535dd2539c01ecd",
      "new_mode": 33188,
      "new_path": "xfa/fgas/font/fgas_stdfontmgr.cpp"
    },
    {
      "type": "modify",
      "old_id": "6e0add1fa58352611787f3c71348e4ffaceda5cc",
      "old_mode": 33188,
      "old_path": "xfa/fgas/localization/fgas_locale.cpp",
      "new_id": "9a8e05cbc7a067e0ef81115596beb3b790c1c114",
      "new_mode": 33188,
      "new_path": "xfa/fgas/localization/fgas_locale.cpp"
    },
    {
      "type": "modify",
      "old_id": "567882d54638d72990835e7e6c5c0c3ffaff83e9",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/app/xfa_ffbarcode.cpp",
      "new_id": "b4608a349e44e4b653b120df99f044f2055d23dc",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/app/xfa_ffbarcode.cpp"
    },
    {
      "type": "modify",
      "old_id": "1fecee7547ab034b206a214843e5c167dc2494d1",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/app/xfa_ffdoc.cpp",
      "new_id": "4b0f67bb6a00c75de01b473a5a077b39b7310a66",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/app/xfa_ffdoc.cpp"
    },
    {
      "type": "modify",
      "old_id": "986e265a45847ea431eb75ae2c006a6fdb605bed",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/app/xfa_ffdocview.cpp",
      "new_id": "7a858748b726edc4b93a5bc85ac6609db2b83e6a",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/app/xfa_ffdocview.cpp"
    },
    {
      "type": "modify",
      "old_id": "72952a7bd9586d82b4a7b452496b61783304b6b7",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/app/xfa_fontmgr.cpp",
      "new_id": "02b44be7899c48be4bb2caf4f4cc4023b8522fb3",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/app/xfa_fontmgr.cpp"
    },
    {
      "type": "modify",
      "old_id": "b2030814bc339ac3ef9d180549f3b719949aca6f",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/app/xfa_textlayout.cpp",
      "new_id": "b259a7f357cb180c4bbfa76ce92ca8b9c0bde2d3",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/app/xfa_textlayout.cpp"
    },
    {
      "type": "modify",
      "old_id": "9cced6a65afee1db0e1e43589d43920d12ad967d",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/app/xfa_textlayout.h",
      "new_id": "ccebff8ad9298c469ed859d68a94a6a952b99506",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/app/xfa_textlayout.h"
    },
    {
      "type": "modify",
      "old_id": "351aedd669a1ee7dcc0527147786627a6840621e",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_fm2jscontext.cpp",
      "new_id": "9ab426d54101a621d7bf352873214dd12a044c84",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_fm2jscontext.cpp"
    },
    {
      "type": "modify",
      "old_id": "4462bd5154bebff110db13976849104bfd326d10",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_lexer.cpp",
      "new_id": "dd3b48ff54f509b67a5f2fe0cd88e58e9621e7ab",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_lexer.cpp"
    },
    {
      "type": "modify",
      "old_id": "f6c12ae64d83a3d3b80cc0f0d9226591d8d1b060",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_simpleexpression.cpp",
      "new_id": "f652961b6ed1361dffa40b70b5facbe8737ba09d",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_simpleexpression.cpp"
    },
    {
      "type": "modify",
      "old_id": "a702527347d7ba2a3d66f4e415b2baf524dc222f",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/cxfa_widgetdata.cpp",
      "new_id": "0c3d065a39a2145742821335eba3b1d6b32278fd",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/cxfa_widgetdata.cpp"
    },
    {
      "type": "modify",
      "old_id": "631b7c10ca7cd16f97d1216ae353080d9810ce3a",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_basic_imp.cpp",
      "new_id": "728ecfc31986823eeed9b3a8f9425842f1db0ced",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_basic_imp.cpp"
    },
    {
      "type": "modify",
      "old_id": "22d3c625c97d014532c0beefb152f55a9f6fca7d",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_document_datamerger_imp.cpp",
      "new_id": "59e663eec112a660d21b8cf1ed677587a4d0a2d9",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_document_datamerger_imp.cpp"
    },
    {
      "type": "modify",
      "old_id": "39bdf2503c5bbc9ddbf58c312fab20242e83972c",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_document_imp.cpp",
      "new_id": "ad3fd70e0d033c28090f15a844049e1d92851f02",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_document_imp.cpp"
    },
    {
      "type": "modify",
      "old_id": "93b596ae996562179b80c640ff68f903090908b9",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_object_imp.cpp",
      "new_id": "fd54b1509b77bd8c1891d31d340d3e29802a9541",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_object_imp.cpp"
    },
    {
      "type": "modify",
      "old_id": "ee95865dc61294454799e3284cb8e4e655aae5d4",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_script_imp.cpp",
      "new_id": "0c8aa1a838f9f474bae43d269c9ccaf02bd62941",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_script_imp.cpp"
    },
    {
      "type": "modify",
      "old_id": "96ae98aeaf89448ffca5119cb1e1395f6d14b609",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_script_nodehelper.cpp",
      "new_id": "96ecc5a125a9e009017379fe8bf240a84cc61ef0",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_script_nodehelper.cpp"
    },
    {
      "type": "modify",
      "old_id": "ecf384b51cc40a7b7ec15e65e40e82758b1d6b55",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_script_resolveprocessor.cpp",
      "new_id": "fcd24bf949ca0d72a46b17fff0d1150531eca67c",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_script_resolveprocessor.cpp"
    },
    {
      "type": "modify",
      "old_id": "4fec7c071b1dfe53cba96047836a2fb32190ef02",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/xfa_utils_imp.cpp",
      "new_id": "77cac00b893f386ba2f187ecf4d2e17470ccb0fb",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/xfa_utils_imp.cpp"
    }
  ]
}