commit bd49a16a1d0b12ace58a0ba717468804be6e8cbd
author Tom Sepez <tsepez@chromium.org> Fri Jul 30 17:54:57 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 30 17:54:57 2021 +0000
tree c6e8b9c87a5f2d6c994cb694ad0b24dd318123f9
parent bc418456d9bde55362270711f107db4d6bd64342

Change one more password arg to ByteString.

Force conversion from raw char* to happen as early as possible once
we cross the public API (implicitly from FPDF_ public string type).

Change-Id: I07f742942d1faf549782b06d6d14edd387da1b5b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83670
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fpdfapi/parser/cpdf_document.cpp

diff --git a/core/fpdfapi/parser/cpdf_document.cpp b/core/fpdfapi/parser/cpdf_document.cpp
index 1f1a784..bb90d99 100644
--- a/core/fpdfapi/parser/cpdf_document.cpp
+++ b/core/fpdfapi/parser/cpdf_document.cpp
@@ -143,7 +143,7 @@
 
 CPDF_Parser::Error CPDF_Document::LoadDoc(
     const RetainPtr<IFX_SeekableReadStream>& pFileAccess,
-    const char* password) {
+    const ByteString& password) {
   if (!m_pParser)
     SetParser(std::make_unique<CPDF_Parser>(this));
 

core/fpdfapi/parser/cpdf_document.h

diff --git a/core/fpdfapi/parser/cpdf_document.h b/core/fpdfapi/parser/cpdf_document.h
index 7c856ed..a296c00 100644
--- a/core/fpdfapi/parser/cpdf_document.h
+++ b/core/fpdfapi/parser/cpdf_document.h
@@ -117,7 +117,7 @@
 
   CPDF_Parser::Error LoadDoc(
       const RetainPtr<IFX_SeekableReadStream>& pFileAccess,
-      const char* password);
+      const ByteString& password);
   CPDF_Parser::Error LoadLinearizedDoc(
       const RetainPtr<CPDF_ReadValidator>& validator,
       const ByteString& password);