tree 2a05322111782bf7b0220ff42401dda9ba32e00e
parent 7ef2ee35613b365df6877c6b072f5b05c6a2daf0
author Tom Sepez <tsepez@chromium.org> 1683328431 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1683328431 +0000

Introduce raw ptr exclusion enforcement to PDFium.

The chromium clang plugin has an option to warn about places where T*
should be re-written to raw_ptr<T>. PDFium, can't enable this warning
directly because it uses UnownedPtr instead of raw_ptr<> since it needs
to support non-PartitionAlloc builds. Someday UnownedPtr will wrap
raw_ptr for PartitionAlloc builds, at which point it will be helpful to
have this warning. So create a pdf_enable_unowned_ptr_exclusion GN arg
to turn this on independently of chromium builds. Then mark the most
obvious places with UNOWNED_PTR_EXCLUSION.

This does not yet compile correctly with the option enabled:
-- Many places ought be converted to UnownedPtr<>.
-- Public headers shouldn't be polluted with this annotation.
-- Tests are unlikely to be converted.

Change-Id: Iec2dc30835b054063c3f32679252889dce4971df
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107131
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>