tree 04aa7977fc0408ec9aa0350f543bdffc509de7ed
parent fe7fa775ed4f9960a89b385d2bf719195ab45016
author Lei Zhang <thestig@chromium.org> 1599599926 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1599599926 +0000

Optimize a tight loop in FX_Number. (try 2)

While doing string to int conversion:
1) Remove a redundant std::isdigit() call.
2) Don't call CheckedNumeric::IsValid() in this case.
- It's almost always valid.
- Continuing in an invalid state does not cause any security issues.

Compare to https://pdfium-review.googlesource.com/72250, the difference
here is the order of operation has been preserved to avoid accidental
overflow.

Bug: chromium:1124998
Change-Id: I5f5f1dce7033bbc42b601bee4e797e50dda97c83
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73338
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>