tree e00389da17e64b45e3b472267bbbcf0e4f1ccd60
parent d9543fca07526c724c4ba08d6ca9c6e8dbb33006
author Tom Sepez <tsepez@chromium.org> 1619553138 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1619553138 +0000

Rename/Re-order some CFX_DIBBase methods.

Do some tidying before attempting to encapsuate m_pAlphaMask. Straight
rename/shuffle, no funny business.

Encapsulation will require a new HasAlphaMask() method, which sounds
too much like the existing HasAlpha() method, so rename that to
IsAlphaFormat(). Then rename IsMask() to IsMaskFormat() for consistency.

Then separate out the palette functions into their own section. In
doing so, notice that GetPaletteSize() is returning a size based on
format, not what was actually allocated for the palette, so rename to
GetRequiredPaletteSize(). Then flag places where we are using this size
rather than the actual size with which a palette span was previously
allocated. Will address those in a follow-up to avoid the possibility
of ever getting a mismatch.

Change-Id: I98c7fb1669a72c8d9dfd5e550b1c1bbbb9c22cb6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79931
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>