tree bb425ba6bcbe0a585870035d281880699330a60b
parent 66245bea278b82101d7462b6a4691186b16dddcb
author Hui Yingst <nigi@chromium.org> 1668550619 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1668550619 +0000

Fix the crash in CFX_SkiaDeviceDriver::StartDIBitsSkia().

The root cause of the crash: the PDF contains hundreds of
concatenation of the matrix (0, 0, 0, 25, 0, 0), which eventually
becomes (-nan, -nan, -nan, -nan, -nan, -nan). This causes crashes when
trying to cast the matrix values into integer.

This CL contains the following fix and improvement:
- [Fix] Add an integer range check before casting and calling
  CStretchEngine::UseInterpolateBilinear() to determine which sampling
  option to use.
- [Improvement] Avoid the process of casting to integers and calling
  CStretchEngine::UseInterpolateBilinear() if the rendering option
  already indicates to use the linear sampling option.

Bug: chromium:1383715
Change-Id: I5e232ae96c917e5c90f9109c8cdb92b573520f47
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101330
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>