tree 1fbf33b0b07775a5d0606cb3972f458cb5e7ba70
parent a131526c697f7f615aef6eb46bc80adf3d6f1742
author Lei Zhang <thestig@chromium.org> 1593019333 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1593019333 +0000

Add CPDF_Dictionary::GetNameFor().

Add a method to make it easy to check a value in a dictionary is a name.
Many parts of the PDF spec require names, but too often PDFium is just
calling CPDF_Dictionary::GetStringFor(), which is not strict enough.

- Document the difference in cpdf_dictionary.h.
- Add unit test to show the difference.
- Use GetStringFor() to simplify some existing name checks.
- Add some missing curly braces per style guide.

Change-Id: Ife9569f6049c07224e1c8826c442ee178650c923
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70852
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>