tree 86f9811281a335cb4ad3d55bcd960bd6a98a1590
parent 5b79f16efda33d168d15b9b739ab789cf4841b2e
author Hui Yingst <nigi@chromium.org> 1568916150 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1568916150 +0000

[SkiaPaths] Vertical texts were drawn in reversed direction.

In ChS_simple.pdf, the Chinese characters are displayed vertically and
when characters are displayed in order, the sentence direction was
going upwards instead of downwards. This is because when the main font
indicates vertical display ("Identity-V"), its descendant font should
inherit the vertical setup since there is only one way to display the
text object. LoadSubstFont() is the only method to sync the descendant
font's |m_bVertical| with the main font, but it was skipped in
CPDF_CIDFont::Load() due to the main font is embedded.

To fix this issue, need to add a step to sync the descendant font's
|m_bVertical| value with the main font if it indicates vertical
display (not default value), regardless whether the main font is
embedded or not. Also this CL calls LoadFontDescriptor() after
|m_pCMap| is initialized to make sure IsVertWriting() returns the
correct value.

Bug: pdfium:1376
Change-Id: I7e935b59745b063b82ec709afd847c6bc289937d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/58611
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>