tree 2cd382984d35f9e9d75b32a4b3d320c53577cd31
parent 60eb21841013d355c1adb06d3984423ad80d5580
author Hui Yingst <nigi@chromium.org> 1601508734 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1601508734 +0000

Fix potential segmentation faults during annotation rendering.

To fix crbug.com/237527, CPDF_Annot::DrawBorder() needs to be called,
which will trigger the following issues:

- In PDF ISO-32000-1:2008 Specification, table 166 indicates that the
  acceptable values for Key "S" in a border style entry are "S", "D",
  "B", "I", "U", which are all single characters. |style[1]| in
  DrawBorder() will be out of bounds.

- CPDF_Annot::DrawBorder() always gets its parameter |pDevice| as
  nullptr from its caller , which will trigger segmentation fault when
  CFX_RenderDevice::GetDeviceType() is called.

This CL fixes the above issues by giving the correct index number for
accessing |style| in CPDF_Annot::DrawBorder(), and making
CPDF_AnnotList::DisplayAnnots() accept a valid CFX_RenderDevice pointer
as a parameter.

This CL also adds a TODO comment regarding adding support for rendering
"Underline" border style.

Bug: chromium:237527
Change-Id: Ie5a23d7a66fa0daba5d22a03eae5c36aae2d3d31
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/74170
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>