)]}' { "commit": "e15a0aad41a54b992957823c202191de33754b7d", "tree": "bfde83e987bd084bcc2f6c942a13da20635f5636", "parents": [ "3bf1244d57b6820ff9b7208947f070151526ada4" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Jul 29 23:59:30 2021 +0000" }, "committer": { "name": "Pdfium LUCI CQ", "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 29 23:59:30 2021 +0000" }, "message": "Prefer string comparisons to hash comparisons.\n\nThe code is easier to read, and it avoids all sorts of unrelated\nstrings being aliased to the hash.\n\n-- add some constexprs\n-- convert some g_Names to kNames\n-- kill some blank lines\n\nChange-Id: I49c3cc9d6e45d427be343dd76921289ab4edf569\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83560\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "2e4296abd92a6130749c0deb8bcb5dfd507800e4", "old_mode": 33188, "old_path": "xfa/fgas/crt/cfgas_stringformatter.cpp", "new_id": "334790969bd23ce50b91b2e9eac241975350dd17", "new_mode": 33188, "new_path": "xfa/fgas/crt/cfgas_stringformatter.cpp" }, { "type": "modify", "old_id": "afdd5ea825a18ea2d152679f7f048cfb05ed35be", "old_mode": 33188, "old_path": "xfa/fgas/crt/cfgas_stringformatter.h", "new_id": "3d0f7cd207013b27425c2d68910910e26ce6bca3", "new_mode": 33188, "new_path": "xfa/fgas/crt/cfgas_stringformatter.h" }, { "type": "modify", "old_id": "f82b77fcb5c8ae957fb845b22780a9dd51b09d76", "old_mode": 33188, "old_path": "xfa/fgas/crt/cfgas_stringformatter_unittest.cpp", "new_id": "183d96770356c050d68bb64ca7bc76259a367ebe", "new_mode": 33188, "new_path": "xfa/fgas/crt/cfgas_stringformatter_unittest.cpp" } ] }